Bug 171287

Summary: [WebCrypto] Enhance ways to convert an ECDSA signature binary into DER format
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jiewen_tan, ryanhaddad, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+
Patch for landing none

Jiewen Tan
Reported 2017-04-25 13:53:07 PDT
Enhance ways to convert an ECDSA signature binary(r||s) into DER format.
Attachments
Patch (5.12 KB, patch)
2017-04-25 14:00 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (3.49 KB, patch)
2017-04-25 14:17 PDT, Jiewen Tan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch for landing (3.49 KB, patch)
2017-04-25 17:42 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2017-04-25 13:53:39 PDT
<rdar://problem/31735332>
Jiewen Tan
Comment 2 2017-04-25 14:00:08 PDT
Created attachment 308138 [details] Patch
Jiewen Tan
Comment 3 2017-04-25 14:17:13 PDT
Created attachment 308143 [details] Patch
Sam Weinig
Comment 4 2017-04-25 15:39:48 PDT
What does it mean this covered by existing tests? Do those tests change their results?
Jiewen Tan
Comment 5 2017-04-25 15:55:11 PDT
(In reply to Sam Weinig from comment #4) > What does it mean this covered by existing tests? Do those tests change > their results? crypto/subtle/ecdsa-import-key-verify-p384.html fails in Internal Bots. After this change, it should pass. That's why this change is covered by existing tests. Please see radars for further information.
Brent Fulgham
Comment 6 2017-04-25 17:31:12 PDT
Comment on attachment 308143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308143&action=review r=me. > Source/WebCore/crypto/mac/CryptoAlgorithmECDSAMac.cpp:147 > + // InitialOctet is needed when the first byte of r/s is larger or equal than 128. "larger or equal than" -> "greater than or equal to"
Jiewen Tan
Comment 7 2017-04-25 17:40:45 PDT
Comment on attachment 308143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308143&action=review Thanks Brent for r+ my patch. >> Source/WebCore/crypto/mac/CryptoAlgorithmECDSAMac.cpp:147 >> + // InitialOctet is needed when the first byte of r/s is larger or equal than 128. > > "larger or equal than" -> "greater than or equal to" Fixed.
Jiewen Tan
Comment 8 2017-04-25 17:42:41 PDT
Created attachment 308176 [details] Patch for landing
WebKit Commit Bot
Comment 9 2017-04-25 21:32:01 PDT
Comment on attachment 308176 [details] Patch for landing Clearing flags on attachment: 308176 Committed r215791: <http://trac.webkit.org/changeset/215791>
Note You need to log in before you can comment on or make changes to this bug.