| Summary: | Enable expired-only reload policy on Mac and iOS | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||||
| Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | alex, beidson, buildbot, cdumez, commit-queue, dbates, esprehn+autocc, gyuyoung.kim, japhet, jlewis3, kling, rniwa, ryanhaddad, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Antti Koivisto
2017-04-25 02:06:34 PDT
Created attachment 308076 [details]
patch
Comment on attachment 308076 [details] patch Attachment 308076 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3600696 New failing tests: fast/dom/navigation-type-reload.html fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html fast/loader/reload-policy-delegate.html Created attachment 308080 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 308076 [details] patch Attachment 308076 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3600732 New failing tests: fast/dom/navigation-type-reload.html fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html fast/loader/reload-policy-delegate.html Created attachment 308087 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 308091 [details]
patch
Created attachment 308093 [details]
patch
Comment on attachment 308093 [details] patch Clearing flags on attachment: 308093 Committed r215730: <http://trac.webkit.org/changeset/215730> All reviewed patches have been landed. Closing bug. Layout Test: fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html is a flaky timeout on Mac Debug WK1 after this change https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r215764%20(781)/results.html Reverted r215730 for reason: The LayoutTest for this change is a flaky timeout on mac-wk1 debug. Committed r215772: <http://trac.webkit.org/changeset/215772> Created attachment 308237 [details]
patch
Comment on attachment 308237 [details] patch Clearing flags on attachment: 308237 Committed r215816: <http://trac.webkit.org/changeset/215816> All reviewed patches have been landed. Closing bug. I've noticed in testing this that the new policy is not used when the web inspector is open and foregrounded. As soon as I bring the browser window to the front and the web inspector to the back, and refresh again, it works (0 bytes transferred). Is that intentional? Seems like it would cause confusion. Yeah, reload triggered from the inspector UI still validates everything. It might make sense to match the behaviour. Could you file a bug for that? |