Bug 171256

Summary: Resource Load Statistics: Clear network process cache when clearing store
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit2Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, buildbot, cdumez, commit-queue, dbates, japhet, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description John Wilander 2017-04-24 18:19:11 PDT
The network process cache needs to be cleared when the statistics store is.
Comment 1 Radar WebKit Bug Importer 2017-04-24 18:22:59 PDT
<rdar://problem/31802347>
Comment 2 John Wilander 2017-04-24 18:49:22 PDT
Created attachment 308041 [details]
Patch
Comment 3 Brent Fulgham 2017-04-25 09:01:38 PDT
Comment on attachment 308041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308041&action=review

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:156
> +    if (clearFirst)

This might have been better named "resetDomain" or something (the 'FIRST' made me think it was a choice between clearing right at the start, versus cleaning it later on).

But I don't feel strongly about this, and I'm not convinced renaming it would be any clearer.
Comment 4 WebKit Commit Bot 2017-04-25 10:05:08 PDT
Comment on attachment 308041 [details]
Patch

Clearing flags on attachment: 308041

Committed r215741: <http://trac.webkit.org/changeset/215741>
Comment 5 WebKit Commit Bot 2017-04-25 10:05:09 PDT
All reviewed patches have been landed.  Closing bug.