Summary: | Import W3C tests for the CSSOM View module | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||
Component: | DOM | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | buildbot, cdumez, rego, youennf | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | Safari 10 | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 5991, 153137, 171226, 171228 | ||||||||||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2017-04-24 03:29:57 PDT
Created attachment 307973 [details]
Patch
Comment on attachment 307973 [details]
Patch
r=me
Can you rerun the importer with -l option so that testharness links are not rewritten?
There are discussions rewriting them' de links to relative, but for the moment I prefer keeping the style consistent.
Comment on attachment 307973 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307973&action=review I guess that for tests that have a few PASS and a few FAIL it's fine to have the "-expected" file with a mix of them. But for the tests with all FAIL, wouldn't be better to mark them as failure in TestExpectations linking to the related bugs to track them? > LayoutTests/imported/w3c/web-platform-tests/cssom-view/cssom-getBoundingClientRect-002-expected.txt:2 > +FAIL getBoundingClientRect on a newly-created Element not yet inserted into the DOM should return an all-zeroes DOMRect assert_equals: DOMRect's x should be zero expected (number) 0 but got (undefined) undefined Shouldn't we mark as Failure this kind of results in TestExpectations linking the the proper bug. Comment on attachment 307973 [details] Patch Attachment 307973 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3594798 New failing tests: imported/w3c/web-platform-tests/cssom-view/Screen-pixelDepth-Screen-colorDepth001.html imported/w3c/web-platform-tests/cssom-view/scrolling-quirks-vs-nonquirks.html Created attachment 307981 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 307987 [details]
Patch
(In reply to Manuel Rego Casasnovas from comment #3) > > LayoutTests/imported/w3c/web-platform-tests/cssom-view/cssom-getBoundingClientRect-002-expected.txt:2 > > +FAIL getBoundingClientRect on a newly-created Element not yet inserted into the DOM should return an all-zeroes DOMRect assert_equals: DOMRect's x should be zero expected (number) 0 but got (undefined) undefined > > Shouldn't we mark as Failure this kind of results in TestExpectations > linking the the proper bug. Done. (In reply to youenn fablet from comment #2) > Comment on attachment 307973 [details] > Patch > > r=me > Can you rerun the importer with -l option so that testharness links are not > rewritten? > There are discussions rewriting them' de links to relative, but for the > moment I prefer keeping the style consistent. Done. Comment on attachment 307987 [details] Patch Attachment 307987 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3596627 New failing tests: imported/w3c/web-platform-tests/cssom-view/Screen-pixelDepth-Screen-colorDepth001.html Created attachment 308012 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 308072 [details]
Patch
Committed r215726: <http://trac.webkit.org/changeset/215726> |