Summary: | test262: test262/test/language/expressions/object/method-definition/early-errors-object-method-duplicate-parameters.js | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
Component: | JavaScriptCore | Assignee: | Joseph Pecoraro <joepeck> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, caitp, commit-queue, joepeck, keith_miller, mark.lam, msaboff, saam | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 170979 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2017-04-22 23:17:40 PDT
Created attachment 307920 [details]
[PATCH] Proposed Fix
*** Bug 161408 has been marked as a duplicate of this bug. *** This might be conflicting due to the other patches I have out for review. But I need to put up a new patch anyways to include addressing the FIXME + tests in 161408. Yes, this adds a tiny change on top of the `yield` patch, so it should come after. Marked as blocking. I'll attach my patch so it doesn't get lost. Created attachment 307923 [details]
[PATCH] Proposed Fix
Comment on attachment 307923 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=307923&action=review r=me > JSTests/stress/async-await-syntax.js:143 > + testSyntaxError(`var outerObject = { async method(a, a) {} }`); > + testSyntaxError(`var outerObject = { async ['meth' + 'od'](a, a) {} }`); > + testSyntaxError(`var outerObject = { async 'method'(a, a) {} }`); > + testSyntaxError(`var outerObject = { async 0(a, a) {} }`); Can you also add some tests that use destructuring and the rest parameter? > LayoutTests/js/script-tests/parser-syntax-check.js:887 > +invalid("({ foo(a,a){} });"); > +invalid("({ foo(b, c, b){} });"); > +invalid("({ *foo(a,a){} });"); > +invalid("({ *foo(b, c, b){} });"); > +invalid("({ async foo(a,a){} });"); > +invalid("({ async foo(b, c, b){} });"); > +valid("({ foo: function(a,a){} });"); > +valid("({ foo: function(b, c, b){} });"); > +valid("({ foo: function*(a,a){} });"); > +valid("({ foo: function*(b, c, b){} });"); > +valid("({ foo: async function(a,a){} });"); > +valid("({ foo: async function(b, c, b){} });"); Can you also add some tests that use destructuring and the rest parameter? Created attachment 308070 [details]
[PATCH] For Landing
Comment on attachment 308070 [details] [PATCH] For Landing Clearing flags on attachment: 308070 Committed r215723: <http://trac.webkit.org/changeset/215723> |