Bug 171188 – [ATK] aria-modal="true" should be exposed via ATK_STATE_MODAL

• Component: Accessibility
• Status: RESOLVED FIXED

[Joanmarie Diggs]

https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaModalTrue

[Radar WebKit Bug Importer]

<rdar://problem/31776306>

[Joanmarie Diggs]

Created attachment 308399 [details]
Patch

[Joanmarie Diggs]

Chris: Please review. Thanks!

[chris fleizach]

Comment on attachment 308399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308399&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:2029
> +    Node* node = this->node();

this node check doesn't seem necessary

> Source/WebCore/accessibility/AccessibilityObject.cpp:2033
> +    AXObjectCache* cache = axObjectCache();

if (AXObjectCache* cache = axObjectCache())
    return cache->ariaModalNode() == node();

return false;

[Joanmarie Diggs]

(In reply to chris fleizach from comment #4)
> Comment on attachment 308399 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=308399&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:2029
> > +    Node* node = this->node();
> 
> this node check doesn't seem necessary

What if we created an AccessibilityObject which lacked a node, and didn't have any nodes with aria-modal="true"?

> > Source/WebCore/accessibility/AccessibilityObject.cpp:2033
> > +    AXObjectCache* cache = axObjectCache();
> 
> if (AXObjectCache* cache = axObjectCache())
>     return cache->ariaModalNode() == node();
> 
> return false;

[chris fleizach]

(In reply to Joanmarie Diggs (irc: joanie) from comment #5)
> (In reply to chris fleizach from comment #4)
> > Comment on attachment 308399 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=308399&action=review
> > 
> > > Source/WebCore/accessibility/AccessibilityObject.cpp:2029
> > > +    Node* node = this->node();
> > 
> > this node check doesn't seem necessary
> 
> What if we created an AccessibilityObject which lacked a node, and didn't
> have any nodes with aria-modal="true"?

hmm yea that would be true

if (AXObjectCache* cache = axObjectCache())
     return node() && cache->ariaModalNode() == node();


> 
> > > Source/WebCore/accessibility/AccessibilityObject.cpp:2033
> > > +    AXObjectCache* cache = axObjectCache();
> > 
> > if (AXObjectCache* cache = axObjectCache())
> >     return cache->ariaModalNode() == node();
> > 
> > return false;

[Joanmarie Diggs]

Created attachment 308543 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 308543 [details]:

media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html bug 168317 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 308543 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 308543 [details]
Patch

Clearing flags on attachment: 308543

Committed r215932: <http://trac.webkit.org/changeset/215932>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.