Bug 171130

Summary: Remove WKCookieManager accept policy functions
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: NEW    
Severity: Normal CC: achristensen, andersca, buildbot, mitz
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Brady Eidson
Reported 2017-04-21 12:35:29 PDT
Remove WKCookieManager accept policy functions These aren't used anymore, and were quite problematic to begin with. Additionally, their existence and support code gets in the way of making cookie storages per-WebsiteDataStore.
Attachments
Patch (17.57 KB, patch)
2017-04-21 16:26 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (17.12 KB, patch)
2017-04-21 17:04 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-04-21 16:26:10 PDT
Created attachment 307831 [details] Patch
Build Bot
Comment 2 2017-04-21 16:27:14 PDT
Attachment 307831 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:270: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 3 2017-04-21 16:33:46 PDT
Ugggggggh WKTR. Nevermind, will have to restore the setter. (for now)
Brady Eidson
Comment 4 2017-04-21 17:04:44 PDT
Created attachment 307841 [details] Patch
Build Bot
Comment 5 2017-04-21 17:06:43 PDT
Attachment 307841 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:270: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 6 2017-04-21 17:16:58 PDT
Removing from review queue for now. Will finish making these go away soon.
Note You need to log in before you can comment on or make changes to this bug.