Bug 171127 – Set defaults video getUserMedia constraints

• Component: Media
• Status: RESOLVED FIXED

[youenn fablet]

Let's select 640x480, 30fps, front camera as the default if no related constraints are defined.

[youenn fablet]

Created attachment 307784 [details]
Patch

[youenn fablet]

Created attachment 307787 [details]
Not adding defaul constraints if not useful

[Eric Carlson]

Comment on attachment 307787 [details]
Not adding defaul constraints if not useful

View in context: https://bugs.webkit.org/attachment.cgi?id=307787&action=review

> LayoutTests/fast/mediastream/getUserMedia-default-expected.txt:5
> +FAIL Checking default video tracks settings except height assert_equals: frame height expected 240 but got 480

This seems wrong.

[Eric Carlson]

Comment on attachment 307787 [details]
Not adding defaul constraints if not useful

r=me with the change we discussed

[youenn fablet]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 307787 [details]
> Not adding defaul constraints if not useful
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=307787&action=review
> 
> > LayoutTests/fast/mediastream/getUserMedia-default-expected.txt:5
> > +FAIL Checking default video tracks settings except height assert_equals: frame height expected 240 but got 480
> 
> This seems wrong.

As discussed directly, this is an issue with the mock source.
Real camera sources are fine as they try to pick the best preset.
We should make mock sources pick presets to get closer to actual camera devices.

[Build Bot]

Comment on attachment 307787 [details]
Not adding defaul constraints if not useful

Attachment 307787 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3579075

New failing tests:
fast/mediastream/MediaStream-video-element-displays-buffer.html

[Build Bot]

Created attachment 307832 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Jon Lee]

(In reply to youenn fablet from comment #5)
> We should make mock sources pick presets to get closer to actual camera
> devices.

Bug ?

[youenn fablet]

(In reply to Jon Lee from comment #8)
> (In reply to youenn fablet from comment #5)
> > We should make mock sources pick presets to get closer to actual camera
> > devices.
> 
> Bug ?

Filed https://bugs.webkit.org/show_bug.cgi?id=171151.
But really, we should be able to mock capture at a lower level so that we exercise the deployed code path.

[youenn fablet]

Created attachment 308019 [details]
Patch for landing

[youenn fablet]

> New failing tests:
> fast/mediastream/MediaStream-video-element-displays-buffer.html

Good to have that test!
This patch was breaking the selection of user/environment camera.
Changed the defaults from a new advanced/exact to existing mandatory/ideal.

[WebKit Commit Bot]

Comment on attachment 308019 [details]
Patch for landing

Clearing flags on attachment: 308019

Committed r215703: <http://trac.webkit.org/changeset/215703>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.