Bug 171115

Summary:

[cmake] WTF target should not have wtf and subdirectries in public interface

Product:

WebKit

Reporter:

Konstantin Tokarev <annulen>

Component:

Tools / Tests

Assignee:

Konstantin Tokarev <annulen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

lforschler, mcatanzaro

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=167343

Attachments:

Description	Flags
Patch	none

Description Konstantin Tokarev 2017-04-21 09:09:54 PDT

In r209665 WEBCORE_FRAMEWORK macro started to export INCLUDE_DIRECTORIES of targets as their public interface, so that linked targets can use them implicitly without copying directory lists around. This matches existing practice for all targets except WTF, headers from which are always included with full path starting from "<wtf/...".

Since r209665 it became possible to include headers from wtf or its subdirectories in CMake builds without using "<wtf/..." path. It should not be allowed.

Comment 1 Konstantin Tokarev 2017-04-21 09:11:43 PDT

Created attachment 307735 [details]
Patch

Comment 2 Konstantin Tokarev 2017-04-21 10:26:09 PDT

Comment on attachment 307735 [details]
Patch

Clearing flags on attachment: 307735

Committed r215614: <http://trac.webkit.org/changeset/215614>

Comment 3 Konstantin Tokarev 2017-04-21 10:26:14 PDT

All reviewed patches have been landed.  Closing bug.