Bug 171064

Summary: [MediaStream] Cleanup and simplify CoreAudioCaptureSource
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: ASSIGNED    
Severity: Normal CC: commit-queue, jer.noble, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Proposed patch. none

Eric Carlson
Reported 2017-04-20 11:26:39 PDT
Cleanup and simplify CoreAudioCaptureSource.
Attachments
Proposed patch. (14.38 KB, patch)
2017-04-20 11:55 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Proposed patch. (12.49 KB, patch)
2017-04-20 15:28 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2017-04-20 11:55:57 PDT
Created attachment 307606 [details] Proposed patch.
Radar WebKit Bug Importer
Comment 2 2017-04-20 11:56:32 PDT
<rdar://problem/31739126>
WebKit Commit Bot
Comment 3 2017-04-20 12:41:34 PDT
Comment on attachment 307606 [details] Proposed patch. Rejecting attachment 307606 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 307606, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 215567 = 21ca1e5ab8d09b64a63c5f1644a6e9d95211a553 r215568 = b5e5a9b2a569a95b33f9c5519d6ddb24814009f5 r215569 = d9062bee880dbf64725274644429046dee9c8165 r215570 = d65eefae247f5205695842423227028e5b073e6b Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/3571496
Eric Carlson
Comment 4 2017-04-20 15:28:59 PDT
Created attachment 307646 [details] Proposed patch.
WebKit Commit Bot
Comment 5 2017-04-20 16:09:35 PDT
Comment on attachment 307646 [details] Proposed patch. Clearing flags on attachment: 307646 Committed r215583: <http://trac.webkit.org/changeset/215583>
Note You need to log in before you can comment on or make changes to this bug.