Summary: | -Wformat warning on HistoryController.cpp:295:5 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
Component: | WebCore Misc. | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, buildbot, cdumez, dbates, japhet, mcatanzaro | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Michael Catanzaro
2017-04-19 18:49:55 PDT
Created attachment 307539 [details]
Patch
Comment on attachment 307539 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307539&action=review I am assuming that -Wall does not include -Wformat and that we do not enable -Wformat on the Mac, iOS, or Windows bots as I have not seen this failure. We should look to enable -Wformat on these bots. > Source/WebCore/ChangeLog:7 > + Please explain the change. (In reply to Daniel Bates from comment #2) > Comment on attachment 307539 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=307539&action=review > > I am assuming that -Wall does not include -Wformat No, -Wall does include -Wformat (at least in GCC). > and that we do not enable > -Wformat on the Mac, iOS, or Windows bots as I have not seen this failure. > We should look to enable -Wformat on these bots. I don't know about that. Certainly the Apple builds seem to be less-strict about such issues. > > Source/WebCore/ChangeLog:7 > > + > > Please explain the change. Aw man. :P Committed r215580: <http://trac.webkit.org/changeset/215580> |