Bug 171019

Summary: Tune GC related JSC options for iOS
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, fpizlo, jfbastien, keith_miller, mark.lam, saam
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Michael Saboff
Reported 2017-04-19 16:02:17 PDT
Empirical tests show that iOS devices perform better with the options values overridden for a smaller number of cores in Options.cpp:overrideDefaults(). These are the options in question: Options::maximumMutatorUtilization() = 0.6; Options::concurrentGCMaxHeadroom() = 1.4; Options::minimumGCPauseMS() = 1; Options::useStochasticMutatorScheduler() = false; <rdar://problem/31718721>
Attachments
Patch (1.20 KB, patch)
2017-04-19 16:05 PDT, Michael Saboff
mark.lam: review+
Michael Saboff
Comment 1 2017-04-19 16:05:29 PDT
Mark Lam
Comment 2 2017-04-19 16:14:23 PDT
Comment on attachment 307517 [details] Patch r=me
JF Bastien
Comment 3 2017-04-19 16:14:56 PDT
Comment on attachment 307517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307517&action=review r=me > Source/JavaScriptCore/runtime/Options.cpp:335 > + { Would it be better to duplicate the block below for iOS and not iOS, or do we expect the tuning parameters to stay the same for both (only the condition above changes)?
Michael Saboff
Comment 4 2017-04-19 16:20:04 PDT
(In reply to JF Bastien from comment #3) > Comment on attachment 307517 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=307517&action=review > > r=me > > > Source/JavaScriptCore/runtime/Options.cpp:335 > > + { > > Would it be better to duplicate the block below for iOS and not iOS, or do > we expect the tuning parameters to stay the same for both (only the > condition above changes)? I opted to do it this way since these are all GC related and don't expect them to change.
Michael Saboff
Comment 5 2017-04-19 16:23:41 PDT
Filip Pizlo
Comment 6 2017-04-19 16:49:58 PDT
Comment on attachment 307517 [details] Patch R=me too
Note You need to log in before you can comment on or make changes to this bug.