Summary: | Vector.h: error: 'auto' not allowed in lambda parameter | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | Web Template Framework | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, benjamin, bfulgham, buildbot, cdumez, cmarcelo, commit-queue, dbates, fpizlo, jfbastien, saam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=171038 | ||||||
Bug Depends on: | 170102, 170994 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2017-04-19 14:32:26 PDT
Created attachment 307509 [details]
Patch
Attachment 307509 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/Vector.h:1526: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 307509 [details]
Patch
r=me
Comment on attachment 307509 [details] Patch Clearing flags on attachment: 307509 Committed r215538: <http://trac.webkit.org/changeset/215538> All reviewed patches have been landed. Closing bug. Comment on attachment 307509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307509&action=review > Source/WTF/ChangeLog:3 > + Vector.h: error: 'auto' not allowed in lambda parameter It is allowed with c++14. The issue is that the project in question is building with c++11 support instead of c++14. I think we should fix this instead. Comment on attachment 307509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307509&action=review >> Source/WTF/ChangeLog:3 >> + Vector.h: error: 'auto' not allowed in lambda parameter > > It is allowed with c++14. The issue is that the project in question is building with c++11 support instead of c++14. I think we should fix this instead. Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig:OTHER_TAPI_FLAGS[sdk=iphone*] = -x objective-c++ -std=c++11 -fno-rtti; We likely want c++14 here. Comment on attachment 307509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307509&action=review >>> Source/WTF/ChangeLog:3 >>> + Vector.h: error: 'auto' not allowed in lambda parameter >> >> It is allowed with c++14. The issue is that the project in question is building with c++11 support instead of c++14. I think we should fix this instead. > > Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig:OTHER_TAPI_FLAGS[sdk=iphone*] = -x objective-c++ -std=c++11 -fno-rtti; > > We likely want c++14 here. I think this also broke the Windows build, so we may want to be careful. Can we roll this out after https://trac.webkit.org/changeset/215560/webkit ? (In reply to Chris Dumez from comment #10) > Can we roll this out after https://trac.webkit.org/changeset/215560/webkit ? It also breaks Windows, so I don't think so. (In reply to Chris Dumez from comment #10) > Can we roll this out after https://trac.webkit.org/changeset/215560/webkit ? I think we can roll this workaround out once we update our Windows build infrastructure to Visual Studio 2017. (In reply to Brent Fulgham from comment #12) > (In reply to Chris Dumez from comment #10) > > Can we roll this out after https://trac.webkit.org/changeset/215560/webkit ? > > I think we can roll this workaround out once we update our Windows build > infrastructure to Visual Studio 2017. I'm wrong! I just rolled this patch out locally, and was able to build WebKit without trouble on Windows. So it looks like VS2015 Update 3's C++14 support is sufficient here. (In reply to Brent Fulgham from comment #13) > (In reply to Brent Fulgham from comment #12) > > (In reply to Chris Dumez from comment #10) > > > Can we roll this out after https://trac.webkit.org/changeset/215560/webkit ? > > > > I think we can roll this workaround out once we update our Windows build > > infrastructure to Visual Studio 2017. > > I'm wrong! > > I just rolled this patch out locally, and was able to build WebKit without > trouble on Windows. So it looks like VS2015 Update 3's C++14 support is > sufficient here. Based on Source/WebKit2/Configurations/Base.xcconfig, we can't roll out this change until we switch to c++14 (or gnu++14) for this: OTHER_TAPI_FLAGS[sdk=iphone*] = -x objective-c++ -std=c++11 -fno-rtti; Ideally, we would not make any C++ headers WebKit SPI, and then we won't need to worry about InstallAPI here. |