Bug 170986

Summary: Avoid repaints for invisible animations on tumblr.com/search/aww
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, kling, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch kling: review+

Antti Koivisto
Reported 2017-04-19 03:57:10 PDT
There is an invisible CSS animation here that is triggering unnecessary repaints.
Attachments
patch (3.98 KB, patch)
2017-04-19 04:05 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-04-19 03:57:26 PDT
<rdar://problem/28644580>
Antti Koivisto
Comment 2 2017-04-19 04:05:15 PDT
Created attachment 307475 [details] patch
Antti Koivisto
Comment 3 2017-04-19 05:18:19 PDT
https://trac.webkit.org/r215507
Darin Adler
Comment 4 2017-04-20 10:44:11 PDT
Comment on attachment 307475 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=307475&action=review > Source/WebCore/rendering/style/RenderStyle.cpp:852 > + if (style.visibility() == HIDDEN) > + return false; > + if (!style.opacity()) > + return false; > + return true; Not at all critical but I would have liked writing it like this: return style.visibility() != HIDDEN && style.opacity(); And probably explicitly specified inline too.
Antti Koivisto
Comment 5 2017-04-20 11:41:26 PDT
> Not at all critical but I would have liked writing it like this: That approach turns incomprehensible when additional and more complex conditions are added (we have plenty of examples). Granted, two conditions is not there yet.
Note You need to log in before you can comment on or make changes to this bug.