Bug 170946

Summary:

Break Document::m_associatedFormControls reference cycle.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Forms

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, dbates, esprehn+autocc, kangil.han, kling, koivisto, wenson_hsieh

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Andreas Kling 2017-04-18 08:40:28 PDT

There's a possible reference cycle between Document and its form elements if the Document gets detached from its frame before the timer started in didAssociateFormControls() fires.

Comment 1 Andreas Kling 2017-04-18 08:41:05 PDT

Created attachment 307384 [details]
Patch

Comment 2 WebKit Commit Bot 2017-04-18 09:34:15 PDT

Comment on attachment 307384 [details]
Patch

Clearing flags on attachment: 307384

Committed r215465: <http://trac.webkit.org/changeset/215465>

Comment 3 WebKit Commit Bot 2017-04-18 09:34:17 PDT

All reviewed patches have been landed.  Closing bug.