Bug 170941

Summary: Update ANGLE
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, Hironori.Fujii
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170980    
Attachments:
Description Flags
Patch
none
Patch achristensen: review+

Dean Jackson
Reported 2017-04-18 04:17:39 PDT
Update ANGLE
Attachments
Patch (9.50 MB, patch)
2017-04-18 04:26 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (9.42 MB, patch)
2017-04-18 04:46 PDT, Dean Jackson 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2017-04-18 04:18:12 PDT
<rdar://problem/31633999>
Dean Jackson
Comment 2 2017-04-18 04:26:16 PDT
Created attachment 307371 [details] Patch
Dean Jackson
Comment 3 2017-04-18 04:28:06 PDT
This first patch won't build. The CMake files are wrong.
Dean Jackson
Comment 4 2017-04-18 04:46:07 PDT
Created attachment 307372 [details] Patch
Alex Christensen
Comment 5 2017-04-18 09:29:32 PDT
Comment on attachment 307372 [details] Patch r=me WebCore changes are just changing ShSomething to sh::Something. Straightforward. The EGL and GLESv2 soft linking was only helping people distributing WinCairo and not wanting to distribute libGLESv2.dll and libEGL.dll, which I think is nobody. If somebody wants to do that, they can bring the soft linking back. It looks like ANGLE now includes an Xcode build in the file you included as Source/ThirdParty/ANGLE/src/angle.xcodeproj/project.pbxproj and maybe we could adopt that sometime. Let's assume no until we find a benefit of doing so. The Apple-added comments in ExpressionParser.cpp, glslang_tab.cpp, and glslang_tab.h remain.
Dean Jackson
Comment 6 2017-04-18 18:13:41 PDT
Committed r215490: <http://trac.webkit.org/changeset/215490>
Note You need to log in before you can comment on or make changes to this bug.