Summary: | com.apple.WebKit.Networking.Development crashed in com.apple.WebKit: WebKit::NetworkRTCProvider::resolvedName | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | Media | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, commit-queue, sam | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
youenn fablet
2017-04-16 12:33:37 PDT
Created attachment 307235 [details]
Patch
Comment on attachment 307235 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307235&action=review > Source/WebKit2/NetworkProcess/webrtc/NetworkRTCProvider.cpp:166 > + CFRelease(host); host should be a RetainPtr<CFHostRef>. It seems odd that this file is using CFHost, and not an abstraction, since it is not guarded by any COCOA or CORE_FOUNDATION guards. If there is a crash, can you provide a test case? If not, can you explain why in the changelog? (In reply to Sam Weinig from comment #2) > Comment on attachment 307235 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=307235&action=review > > > Source/WebKit2/NetworkProcess/webrtc/NetworkRTCProvider.cpp:166 > > + CFRelease(host); > > host should be a RetainPtr<CFHostRef>. It seems odd that this file is using > CFHost, and not an abstraction, since it is not guarded by any COCOA or > CORE_FOUNDATION guards. I'll update the patch to use RetainPtr. NetworkRTCProvider is Cocoa specific at the moment. We will see how to make NetworkRTCProvider abstract when/if other ports will start supporting libwebrtc backend. Other ports may actually want to directly implement the future model we intent to follow for COCOA: create sockets on the UIProcess, pass them to the WebProcess and do networking in the WebProcess. (In reply to Sam Weinig from comment #3) > If there is a crash, can you provide a test case? If not, can you explain > why in the changelog? It is difficult to provide a test case. The crash happens in case the Resolver is destroyed after being stopped. CFHostCancelInfoResolution is called but sometimes NetworkRTCProvider::resolvedName is called after the resolver being cancelled. These additional clean-up lines will hopefully make sure things work well. Created attachment 307283 [details]
Patch
Comment on attachment 307283 [details] Patch Clearing flags on attachment: 307283 Committed r215443: <http://trac.webkit.org/changeset/215443> All reviewed patches have been landed. Closing bug. |