| Summary: | Add an external libwebrtc encoder factory in WebCore | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
| Component: | Media | Assignee: | youenn fablet <youennf> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | achristensen, buildbot, commit-queue, rniwa | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
youenn fablet
2017-04-15 22:36:51 PDT
Created attachment 307218 [details]
Patch
Attachment 307218 [details] did not pass style-queue:
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.h:23: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.h:31: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:63: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/ThirdParty/libwebrtc/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/ThirdParty/libwebrtc/ChangeLog:13: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/ThirdParty/libwebrtc/ChangeLog:14: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:38: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:38: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:51: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:55: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_encoder.h:168: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_encoder.h:168: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_encoder.h:186: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 15 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 307218 [details] Patch Attachment 307218 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3544135 New failing tests: webrtc/captureCanvas-webrtc.html Created attachment 307221 [details]
Archive of layout-test-results from ews101 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 307218 [details] Patch Attachment 307218 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3544160 New failing tests: webrtc/video.html webrtc/libwebrtc/descriptionGetters.html webrtc/captureCanvas-webrtc.html webrtc/ephemeral-certificates-and-cnames.html Created attachment 307222 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 307240 [details]
Patch
Attachment 307240 [details] did not pass style-queue:
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.h:23: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.h:31: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.h:33: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/mediastream/libwebrtc/VideoToolBoxEncoderFactory.h:42: supported_codecs is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:63: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/ThirdParty/libwebrtc/ChangeLog:12: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/ThirdParty/libwebrtc/ChangeLog:15: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/ThirdParty/libwebrtc/ChangeLog:16: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:38: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:38: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:51: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:55: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_encoder.h:168: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_encoder.h:168: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_encoder.h:186: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 17 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 307245 [details]
Patch
Attachment 307245 [details] did not pass style-queue:
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.h:23: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.h:32: The parameter name "codec" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.h:32: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:63: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/ThirdParty/libwebrtc/ChangeLog:12: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/ThirdParty/libwebrtc/ChangeLog:15: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/ThirdParty/libwebrtc/ChangeLog:16: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:38: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:38: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:46: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:51: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:51: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_decoder.h:55: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_encoder.h:168: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_encoder.h:168: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/video_encoder.h:186: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 16 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 307245 [details] Patch Clearing flags on attachment: 307245 Committed r215411: <http://trac.webkit.org/changeset/215411> All reviewed patches have been landed. Closing bug. |