Bug 170861 – Use AVAudioSession to enumerate audio capture devices on iOS

• Component: Media
• Status: RESOLVED FIXED

[Jeremy Jones]

Right now iOS is using AVCaptureDeviceManager, but it should move to AVAudioSession.

[Radar WebKit Bug Importer]

<rdar://problem/31653658>

[Jer Noble]

Created attachment 308763 [details]
Patch

[Eric Carlson]

Comment on attachment 308763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308763&action=review

> Source/WebCore/ChangeLog:10
> +        Hook up the new AVAudioSessionCaptureDeviceManager class to CoreAudioCaptureSource and to the (increasingly ill-named)
> +        RealtimeMediaSourceCenterMac.

Magic eight ball says "Outlook good for a rename"

[WebKit Commit Bot]

Comment on attachment 308763 [details]
Patch

Clearing flags on attachment: 308763

Committed r216029: <http://trac.webkit.org/changeset/216029>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

(In reply to WebKit Commit Bot from comment #4)
> Comment on attachment 308763 [details]
> Patch
> 
> Clearing flags on attachment: 308763
> 
> Committed r216029: <http://trac.webkit.org/changeset/216029>

As EWS predicted, this broke the iOS build:

https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20%28Build%29/builds/1264

[Ryan Haddad]

(In reply to Ryan Haddad from comment #6)
> (In reply to WebKit Commit Bot from comment #4)
> > Comment on attachment 308763 [details]
> > Patch
> > 
> > Clearing flags on attachment: 308763
> > 
> > Committed r216029: <http://trac.webkit.org/changeset/216029>
> 
> As EWS predicted, this broke the iOS build:
> 
> https://build.webkit.org/builders/
> Apple%20iOS%2010%20Simulator%20Release%20%28Build%29/builds/1264

Apparently I left this comment 20 seconds after a fix was landed in https://trac.webkit.org/r216034

[Jer Noble]

(In reply to Ryan Haddad from comment #7)
> (In reply to Ryan Haddad from comment #6)
> > (In reply to WebKit Commit Bot from comment #4)
> > > Comment on attachment 308763 [details]
> > > Patch
> > > 
> > > Clearing flags on attachment: 308763
> > > 
> > > Committed r216029: <http://trac.webkit.org/changeset/216029>
> > 
> > As EWS predicted, this broke the iOS build:
> > 
> > https://build.webkit.org/builders/
> > Apple%20iOS%2010%20Simulator%20Release%20%28Build%29/builds/1264
> 
> Apparently I left this comment 20 seconds after a fix was landed in
> https://trac.webkit.org/r216034

My apologies. I was building against an old ToT where this error didn't show up.