Bug 170805

Summary: Don't invalidate composition for style changes in non-composited layers
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
buildbot: commit-queue-
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
patch
none
patch
none
patch simon.fraser: review+

Description Antti Koivisto 2017-04-13 02:36:54 PDT
They can only affect composition via layout so invalidation during style change is unnecessary. Composition updates are expensive, this can save a lot of work.
Comment 1 Antti Koivisto 2017-04-13 02:45:55 PDT
Created attachment 306981 [details]
patch
Comment 2 Build Bot 2017-04-13 04:05:47 PDT
Comment on attachment 306981 [details]
patch

Attachment 306981 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3528381

New failing tests:
css3/blending/blend-mode-isolation-flags-turn-off-blending.html
css3/blending/blend-mode-isolation-flags-turn-on-stacking-context.html
Comment 3 Build Bot 2017-04-13 04:05:48 PDT
Created attachment 306982 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-04-13 04:23:11 PDT
Comment on attachment 306981 [details]
patch

Attachment 306981 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3528383

New failing tests:
css3/blending/blend-mode-isolation-flags-turn-off-blending.html
css3/blending/blend-mode-isolation-flags-turn-on-stacking-context.html
Comment 5 Build Bot 2017-04-13 04:23:12 PDT
Created attachment 306984 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 6 Antti Koivisto 2017-04-13 06:18:42 PDT
Created attachment 306986 [details]
patch
Comment 7 Antti Koivisto 2017-04-13 06:42:39 PDT
Created attachment 306987 [details]
patch
Comment 8 Antti Koivisto 2017-04-13 08:24:44 PDT
Created attachment 306989 [details]
patch
Comment 9 Radar WebKit Bug Importer 2017-04-13 08:35:32 PDT
<rdar://problem/31606185>
Comment 10 Antti Koivisto 2017-04-13 16:21:22 PDT
https://trac.webkit.org/r215347