Summary: | [WinCairo] Assign WEBKIT_LIBRARIES_DIR to CMAKE_PREFIX_PATH | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||
Component: | Tools / Tests | Assignee: | Don Olmstead <don.olmstead> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, commit-queue, don.olmstead, Hironori.Fujii, lforschler | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Don Olmstead
2017-04-12 17:39:31 PDT
Just a heads up that FIND_LIBRARY_USE_LIB32_PATHS doesn't appear to be available until CMake 3.7. This means the same ideas cannot currently be applied to AppleWin. WinCairo only does 64 bit builds so this limitation isn't there. Created attachment 306957 [details]
Patch with CMake changes
(In reply to Don Olmstead from comment #1) > Just a heads up that FIND_LIBRARY_USE_LIB32_PATHS doesn't appear to be > available until CMake 3.7. This means the same ideas cannot currently be > applied to AppleWin. WinCairo only does 64 bit builds so this limitation > isn't there. Then we shouldn't use it yet. (In reply to Alex Christensen from comment #3) > (In reply to Don Olmstead from comment #1) > > Just a heads up that FIND_LIBRARY_USE_LIB32_PATHS doesn't appear to be > > available until CMake 3.7. This means the same ideas cannot currently be > > applied to AppleWin. WinCairo only does 64 bit builds so this limitation > > isn't there. > > Then we shouldn't use it yet. When do the AppleWin bots get updated? Our WinCairo buildbot has CMake 3.7.2 and should soon have 3.8.0 installed on it. I foresee us requiring at least 3.8.0 for WinCairo development in the near future as we're about ready to update the libraries and find_package(OpenSSL) does not properly detect libressl on Windows until 3.8.0. Comment on attachment 306957 [details]
Patch with CMake changes
Let's assume updating anything in the AppleWin build tools takes a really long time.
Comment on attachment 306957 [details] Patch with CMake changes Clearing flags on attachment: 306957 Committed r215326: <http://trac.webkit.org/changeset/215326> All reviewed patches have been landed. Closing bug. |