| Summary: | SVG SMIL animation is currently broken (and turned off) (affects Acid3 tests 75 and 76) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | gavin.sharp, koivisto, webmaster | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Mac | ||||||||
| OS: | OS X 10.5 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 17064 | ||||||||
| Attachments: |
|
||||||||
|
Description
Eric Seidel (no email)
2008-01-29 14:49:11 PST
The test itself does not look very demanding. As far as I can see the only missing feature is the support for beginElement() and perhaps some bug fixes to baseVal/animVal. (In reply to comment #1) > The test itself does not look very demanding. But implementing SMIL must be about getting a rock solid implementation per se, right? Or is passing Acid3 a value in itself? (Not in my book!) Test suites like this one should be more important to pass: http://www.w3.org/2001/SMIL20/testsuite/ Created attachment 20075 [details]
patch for test 75
Amusingly this no-op patch which simply adds ElementTimeControl interface is sufficient for passing test 75.
Test 76 will actually require enabling animation support!
Comment on attachment 20075 [details]
patch for test 75
We'll need to add the new files to the other 4 build systems (WebCore.vcproj, WebCore.pro, GNUMakefile.am, and WebCoreSources.bkl).
You're missing a newline at the end of ElementTimeControl.idl
r=me if you fix the above.
Sending WebCore/ChangeLog Sending WebCore/DerivedSources.make Sending WebCore/WebCore.pro Sending WebCore/WebCore.vcproj/WebCore.vcproj Sending WebCore/WebCore.xcodeproj/project.pbxproj Sending WebCore/bindings/scripts/CodeGeneratorObjC.pm Adding WebCore/svg/ElementTimeControl.h Adding WebCore/svg/ElementTimeControl.idl Sending WebCore/svg/SVGAnimationElement.cpp Sending WebCore/svg/SVGAnimationElement.h Sending WebCore/svg/SVGAnimationElement.idl Transmitting file data ........... Committed revision 31315. Created attachment 20104 [details]
enable animation & implement beginElement()
This fixes test 76.
Comment on attachment 20104 [details]
enable animation & implement beginElement()
r=me
Sending WebCore/ChangeLog Sending WebCore/Configurations/WebCore.xcconfig Sending WebCore/svg/SVGAnimationElement.cpp Sending WebCore/svg/SVGAnimationElement.h Sending WebKitTools/ChangeLog Sending WebKitTools/Scripts/build-webkit Transmitting file data ...... Committed revision 31334. |