| Summary: | Provide a viewport parameter to disable clipping to the safe area | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||
| Severity: | Normal | CC: | bdakin, dino, eoconnor, jonlee, sam, simon.fraser | ||||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||
|
Description
Tim Horton
2017-04-12 01:23:24 PDT
Created attachment 306894 [details]
Patch
We should also separately consider improving the margin tile mechanism -- we could extend the normal tiles into the insets, for example, to reduce memory overhead. Comment on attachment 306894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306894&action=review > Source/WebCore/dom/ViewportArguments.h:54 > float shrinkToFit; > + float clipToDocument; Can we stop this madness? Comment on attachment 306894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306894&action=review >> Source/WebCore/dom/ViewportArguments.h:54 >> + float clipToDocument; > > Can we stop this madness? Agreed. Why this float? Created attachment 306950 [details]
Patch
Created attachment 306953 [details]
add a second test
Created attachment 306956 [details]
Patch
Repaints in the margins are getting clipped out in GraphicsLayerCA::setNeedsDisplayInRect... (In reply to Tim Horton from comment #9) > Repaints in the margins are getting clipped out in > GraphicsLayerCA::setNeedsDisplayInRect... ... because the RenderView's layer isn't extended into the margins. Created attachment 307025 [details]
Patch
Created attachment 307164 [details]
Patch
Created attachment 307172 [details]
Patch
Created attachment 307173 [details]
Patch
Comment on attachment 307173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307173&action=review > Source/WebCore/page/ViewportConfiguration.cpp:341 > + m_configuration.clipToSafeArea = m_viewportArguments.clipToSafeArea != 0.; This can just be assignment now. Created attachment 307280 [details]
Patch
Created attachment 307281 [details]
Patch
|