Bug 170766

Summary:

Provide a viewport parameter to disable clipping to the safe area

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, dino, eoconnor, jonlee, sam, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
add a second test	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	bdakin: review+

Tim Horton

Reported 2017-04-12 01:23:24 PDT

Provide a viewport parameter to disable clipping to the document rect

Attachments
Patch (35.36 KB, patch) 2017-04-12 01:27 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (36.53 KB, patch) 2017-04-12 16:46 PDT, Tim Horton	no flags	Details Formatted Diff Diff
add a second test (39.61 KB, patch) 2017-04-12 17:06 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (39.61 KB, patch) 2017-04-12 17:50 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (16.81 KB, patch) 2017-04-13 14:32 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (40.38 KB, patch) 2017-04-14 16:12 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (40.37 KB, patch) 2017-04-14 17:46 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (40.37 KB, patch) 2017-04-14 17:48 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (373.04 KB, patch) 2017-04-17 10:46 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Patch (40.50 KB, patch) 2017-04-17 10:52 PDT, Tim Horton	bdakin: review+	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2017-04-12 01:27:08 PDT

Created attachment 306894 [details] Patch

Tim Horton

Comment 2 2017-04-12 01:27:55 PDT

<rdar://problem/31564634>

Tim Horton

Comment 3 2017-04-12 01:28:49 PDT

We should also separately consider improving the margin tile mechanism -- we could extend the normal tiles into the insets, for example, to reduce memory overhead.

Simon Fraser (smfr)

Comment 4 2017-04-12 01:49:55 PDT

Comment on attachment 306894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306894&action=review > Source/WebCore/dom/ViewportArguments.h:54 > float shrinkToFit; > + float clipToDocument; Can we stop this madness?

Sam Weinig

Comment 5 2017-04-12 05:58:58 PDT

Comment on attachment 306894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306894&action=review >> Source/WebCore/dom/ViewportArguments.h:54 >> + float clipToDocument; > > Can we stop this madness? Agreed. Why this float?

Tim Horton

Comment 6 2017-04-12 16:46:17 PDT

Created attachment 306950 [details] Patch

Tim Horton

Comment 7 2017-04-12 17:06:39 PDT

Created attachment 306953 [details] add a second test

Tim Horton

Comment 8 2017-04-12 17:50:14 PDT

Created attachment 306956 [details] Patch

Tim Horton

Comment 9 2017-04-13 13:58:28 PDT

Repaints in the margins are getting clipped out in GraphicsLayerCA::setNeedsDisplayInRect...

Tim Horton

Comment 10 2017-04-13 14:05:39 PDT

(In reply to Tim Horton from comment #9) > Repaints in the margins are getting clipped out in > GraphicsLayerCA::setNeedsDisplayInRect... ... because the RenderView's layer isn't extended into the margins.

Tim Horton

Comment 11 2017-04-13 14:32:11 PDT

Created attachment 307025 [details] Patch

Tim Horton

Comment 12 2017-04-14 16:12:35 PDT

Created attachment 307164 [details] Patch

Tim Horton

Comment 13 2017-04-14 17:46:39 PDT

Created attachment 307172 [details] Patch

Tim Horton

Comment 14 2017-04-14 17:48:55 PDT

Created attachment 307173 [details] Patch

Tim Horton

Comment 15 2017-04-17 10:10:42 PDT

Comment on attachment 307173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307173&action=review > Source/WebCore/page/ViewportConfiguration.cpp:341 > + m_configuration.clipToSafeArea = m_viewportArguments.clipToSafeArea != 0.; This can just be assignment now.

Tim Horton

Comment 16 2017-04-17 10:46:52 PDT

Created attachment 307280 [details] Patch

Tim Horton

Comment 17 2017-04-17 10:52:11 PDT

Created attachment 307281 [details] Patch

Tim Horton

Comment 18 2017-04-17 13:25:24 PDT

https://trac.webkit.org/changeset/215425/webkit

Note You need to log in before you can comment on or make changes to this bug.