Bug 170753

Summary: Implement Object.isFrozen() and Object.isSealed() per ECMA spec
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, keith_miller, mark.lam, saam
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Michael Saboff
Reported 2017-04-11 15:43:23 PDT
Our implementations for isFrozen() & isSealed() have special cases for JSFinalObjects that do not properly implement the semantics described in the ECMA standard. The describes isFrozen() & isSealed() in terms of an abstract operation TestIntegrityLevel() <https://tc39.github.io/ecma262/#sec-testintegritylevel>. We should implement TestIntegrityLevel() similar to how we implemented setIntegrityLevel() and use it for isFrozen() & isSealed(). <rdar://problem/31567008>
Attachments
Patch (46.17 KB, patch)
2017-04-11 15:59 PDT, Michael Saboff 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2017-04-11 15:59:09 PDT
Created attachment 306869 [details] Patch
Mark Lam
Comment 2 2017-04-11 20:52:35 PDT
Comment on attachment 306869 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306869&action=review r=me > JSTests/ChangeLog:12 > + roperties of an Object. This is behanvior is considered undefined typo: /roperties/properties/, /is behanvior/behavior/
Michael Saboff
Comment 3 2017-04-12 10:36:45 PDT
Fix landed in change set r215272 <https://trac.webkit.org/changeset/215272>
Note You need to log in before you can comment on or make changes to this bug.