Bug 170750

Summary: BreakingContext::WordTrailingSpace cleanup.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, mmaxfield, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zalan
Reported 2017-04-11 14:29:41 PDT
SSIA.
Attachments
Patch (4.97 KB, patch)
2017-04-11 14:35 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (4.99 KB, patch)
2017-04-13 09:56 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2017-04-11 14:35:15 PDT
Created attachment 306852 [details] Patch
Myles C. Maxfield
Comment 2 2017-04-12 22:00:39 PDT
Comment on attachment 306852 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306852&action=review > Source/WebCore/rendering/line/BreakingContext.h:67 > + WordTrailingSpace(const RenderStyle& style, bool measuringWithTrailingWhitespaceIsEnabled = true) I'd get rid of the "Is" from the name. > Source/WebCore/rendering/line/BreakingContext.h:834 > + WordTrailingSpace wordTrailingSpace(style, !textLayout); Wow, Lyin' width measurements really went wacko today. Made all sorts of crazy repaint errors. Can't function under complex scripts - not very presidential. Sad!
zalan
Comment 3 2017-04-13 09:56:22 PDT
Created attachment 306992 [details] Patch
WebKit Commit Bot
Comment 4 2017-04-13 10:39:06 PDT
Comment on attachment 306992 [details] Patch Clearing flags on attachment: 306992 Committed r215325: <http://trac.webkit.org/changeset/215325>
WebKit Commit Bot
Comment 5 2017-04-13 10:39:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.