Bug 170750

Summary:

BreakingContext::WordTrailingSpace cleanup.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, mmaxfield, simon.fraser, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2017-04-11 14:29:41 PDT

SSIA.

Comment 1 zalan 2017-04-11 14:35:15 PDT

Created attachment 306852 [details]
Patch

Comment 2 Myles C. Maxfield 2017-04-12 22:00:39 PDT

Comment on attachment 306852 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306852&action=review

> Source/WebCore/rendering/line/BreakingContext.h:67
> +    WordTrailingSpace(const RenderStyle& style, bool measuringWithTrailingWhitespaceIsEnabled = true)

I'd get rid of the "Is" from the name.

> Source/WebCore/rendering/line/BreakingContext.h:834
> +    WordTrailingSpace wordTrailingSpace(style, !textLayout);

Wow, Lyin' width measurements really went wacko today. Made all sorts of crazy repaint errors. Can't function under complex scripts - not very presidential. Sad!

Comment 3 zalan 2017-04-13 09:56:22 PDT

Created attachment 306992 [details]
Patch

Comment 4 WebKit Commit Bot 2017-04-13 10:39:06 PDT

Comment on attachment 306992 [details]
Patch

Clearing flags on attachment: 306992

Committed r215325: <http://trac.webkit.org/changeset/215325>

Comment 5 WebKit Commit Bot 2017-04-13 10:39:08 PDT

All reviewed patches have been landed.  Closing bug.