Bug 170731

Summary: WebKitTestRunner/DumpRenderTree prevent device from sleeping
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2017-04-11 08:38:43 PDT
Prevent the device from sleeping while running tests.
Attachments
Patch (2.20 KB, patch)
2017-04-11 08:43 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.75 KB, patch)
2017-04-11 10:12 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-04-11 08:39:27 PDT
<rdar://problem/31556961>
Jonathan Bedard
Comment 2 2017-04-11 08:43:10 PDT
Created attachment 306820 [details] Patch
Jonathan Bedard
Comment 3 2017-04-11 08:44:37 PDT
Comment on attachment 306820 [details] Patch Removing review flag while I confirm that the toggle is actually needed.
Jonathan Bedard
Comment 4 2017-04-11 10:12:46 PDT
Created attachment 306829 [details] Patch
Jonathan Bedard
Comment 5 2017-04-11 10:13:55 PDT
We can set this when beginning the test suite. That seems to be the correct way of doing this.
Alex Christensen
Comment 6 2017-04-12 01:36:15 PDT
Comment on attachment 306829 [details] Patch Do we need to unset this?
Jonathan Bedard
Comment 7 2017-04-12 08:11:44 PDT
(In reply to Alex Christensen from comment #6) > Comment on attachment 306829 [details] > Patch > > Do we need to unset this? No, it only persists for the lifetime of the testing app, which we kill when testing is finished.
Alex Christensen
Comment 8 2017-04-28 13:40:21 PDT
Comment on attachment 306829 [details] Patch r=me Maybe we could just put the setting of idleTimerDisabled into setUpIOSLayoutTestCommunication to reduce duplication, and maybe we could rename that function. Maybe not.
Jonathan Bedard
Comment 9 2017-04-28 13:44:11 PDT
(In reply to Alex Christensen from comment #8) > Comment on attachment 306829 [details] > Patch > > r=me > Maybe we could just put the setting of idleTimerDisabled into > setUpIOSLayoutTestCommunication to reduce duplication, and maybe we could > rename that function. Maybe not. That function is specifically designed for setting up the communication, it's used for nothing else. I think duplication is better in this case, if we find we need to do more shared IOS setup between DumpRenderTree and WebKitTestRunnerApp in the future, I will investigate more code sharing.
WebKit Commit Bot
Comment 10 2017-04-28 13:51:00 PDT
Comment on attachment 306829 [details] Patch Clearing flags on attachment: 306829 Committed r215942: <http://trac.webkit.org/changeset/215942>
WebKit Commit Bot
Comment 11 2017-04-28 13:51:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.