Bug 170722

Summary:

[Modern Media Controls] Allow modern-media-controls to be provided through WebKitAdditions

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none

Antoine Quint

Reported 2017-04-11 02:46:42 PDT

Allow modern-media-controls to be provided through WebKitAdditions.

Attachments
Patch (2.98 KB, patch) 2017-04-11 02:48 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch for landing (2.97 KB, patch) 2017-04-11 14:29 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch for landing (2.97 KB, patch) 2017-04-11 15:29 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-04-11 02:48:14 PDT

<rdar://problem/31553089>

Antoine Quint

Comment 2 2017-04-11 02:48:54 PDT

Created attachment 306790 [details] Patch

WebKit Commit Bot

Comment 3 2017-04-11 11:41:43 PDT

Comment on attachment 306790 [details] Patch Clearing flags on attachment: 306790 Committed r215245: <http://trac.webkit.org/changeset/215245>

WebKit Commit Bot

Comment 4 2017-04-11 11:41:44 PDT

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 5 2017-04-11 12:51:47 PDT

Reverted r215245 for reason: This change broke internal builds. Committed r215248: <http://trac.webkit.org/changeset/215248>

Antoine Quint

Comment 6 2017-04-11 14:29:59 PDT

Created attachment 306850 [details] Patch for landing

WebKit Commit Bot

Comment 7 2017-04-11 15:12:08 PDT

Comment on attachment 306850 [details] Patch for landing Rejecting attachment 306850 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 306850, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Tools/Scripts/webkitdirs.pm line 2689. Failed to run "['Tools/Scripts/update-webkit']" exit_code: 1 Updating OpenSource RA layer request failed: Unable to connect to a repository at URL 'http://svn.webkit.org/repository/webkit': OPTIONS of 'http://svn.webkit.org/repository/webkit': could not connect to server (http://svn.webkit.org) at /Applications/Xcode.app/Contents/Developer/usr/share/git-core/perl/Git/SVN.pm line 718. Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2689. Full output: http://webkit-queues.webkit.org/results/3520101

Antoine Quint

Comment 8 2017-04-11 15:29:34 PDT

Created attachment 306865 [details] Patch for landing

WebKit Commit Bot

Comment 9 2017-04-11 16:03:50 PDT

Comment on attachment 306865 [details] Patch for landing Clearing flags on attachment: 306865 Committed r215254: <http://trac.webkit.org/changeset/215254>

WebKit Commit Bot

Comment 10 2017-04-11 16:03:52 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.