Bug 170704

Summary: LayoutTest webrtc/video-mute.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson, jonlee, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=171497
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Ryan Haddad
Reported 2017-04-10 16:01:16 PDT
LayoutTest webrtc/video-mute.html is a flaky failure https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r215183%20(405)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2Fvideo-mute.html --- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/webrtc/video-mute-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/webrtc/video-mute-actual.txt @@ -1,4 +1,4 @@ -PASS Outgoing muted/unmuted video track +FAIL Outgoing muted/unmuted video track assert_false: track is reenabled, video is not black expected false got true
Attachments
Patch (1.24 KB, patch)
2017-04-10 17:30 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (3.06 KB, patch)
2017-04-13 17:03 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.08 KB, patch)
2017-04-17 14:23 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2017-04-10 16:02:29 PDT
This test is a flaky failure on Sierra Debug WK2 and iOS 10 Simulator Release WK2, but it seems to be failing or crashing on every run on iOS 10 Simulator Debug WK2.
youenn fablet
Comment 2 2017-04-10 17:30:24 PDT
Created attachment 306763 [details] Patch
WebKit Commit Bot
Comment 3 2017-04-11 15:48:19 PDT
Comment on attachment 306763 [details] Patch Clearing flags on attachment: 306763 Committed r215253: <http://trac.webkit.org/changeset/215253>
WebKit Commit Bot
Comment 4 2017-04-11 15:48:21 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 5 2017-04-13 12:35:23 PDT
This test is still flaky. Reopening.
Ryan Haddad
Comment 6 2017-04-13 15:48:42 PDT
Marked test as flaky in https://trac.webkit.org/changeset/215344/webkit
youenn fablet
Comment 7 2017-04-13 17:03:50 PDT
Created attachment 307049 [details] Patch
Eric Carlson
Comment 8 2017-04-17 14:20:43 PDT
Comment on attachment 307049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307049&action=review > LayoutTests/webrtc/video-mute.html:10 > + <video id="video" autoplay="" width="640" height="480"></video> Nit: this isn't XML, so the autoplay attribute doesn't need a value.
youenn fablet
Comment 9 2017-04-17 14:23:08 PDT
Created attachment 307296 [details] Patch for landing
WebKit Commit Bot
Comment 10 2017-04-17 15:04:59 PDT
Comment on attachment 307296 [details] Patch for landing Clearing flags on attachment: 307296 Committed r215434: <http://trac.webkit.org/changeset/215434>
WebKit Commit Bot
Comment 11 2017-04-17 15:05:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.