Summary: | test262: test262/test/language/literals/regexp/u-dec-esc.js | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
Component: | JavaScriptCore | Assignee: | Joseph Pecoraro <joepeck> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | buildbot, commit-queue, joepeck, keith_miller, mark.lam, msaboff, saam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Joseph Pecoraro
2017-04-10 12:38:03 PDT
Seems there are some test262 tests that cover this, and we do fail them: test262/test/language/literals/regexp/u-dec-esc.js test262/test/language/literals/regexp/u-invalid-legacy-octal-escape.js test262/test/language/literals/regexp/u-invalid-oob-decimal-escape.js Created attachment 306789 [details]
[PATCH] For Bots
Attachment 306789 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:898: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:899: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:900: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:901: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:902: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:903: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:904: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:905: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:906: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:907: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:908: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:909: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:910: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:911: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:912: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:913: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:914: One space before end of line comments [whitespace/comments] [5]
Total errors found: 17 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 306821 [details]
[PATCH] Proposed Fix
Attachment 306821 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:898: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:899: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:900: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:901: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:902: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:903: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:904: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:905: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:906: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:907: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:908: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:909: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:910: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:911: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:912: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:913: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/yarr/YarrPattern.cpp:914: One space before end of line comments [whitespace/comments] [5]
Total errors found: 17 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 306821 [details]
[PATCH] Proposed Fix
r=me
Comment on attachment 306821 [details] [PATCH] Proposed Fix Clearing flags on attachment: 306821 Committed r215311: <http://trac.webkit.org/changeset/215311> All reviewed patches have been landed. Closing bug. |