Bug 170657

Summary: [DFG] Handle String.prototype.indexOf
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: NEW    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Yusuke Suzuki
Reported 2017-04-09 14:46:04 PDT
...
Attachments
Patch (36.39 KB, patch)
2017-04-13 10:23 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (40.60 KB, patch)
2017-04-13 20:04 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (35.28 KB, patch)
2019-01-09 00:01 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-04-13 10:23:59 PDT
Created attachment 306993 [details] Patch WIP: microbenchmark shows 1.5x improvement. But ARES-6 Babylon does not show much... I think this is because indexOf() in Babylon is long enough to amortize indexOf's setups. But in that case, we have a chance to optimize it significantly by using SSE4.2 here. Investigating.
Yusuke Suzuki
Comment 2 2017-04-13 10:25:19 PDT
Comment on attachment 306993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306993&action=review > Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:3935 > + // instead of roundss. I think this is the reason!
Yusuke Suzuki
Comment 3 2017-04-13 20:04:41 PDT
Created attachment 307079 [details] Patch WIP: make more solid
Yusuke Suzuki
Comment 4 2019-01-09 00:01:58 PST
Created attachment 358678 [details] Patch
Note You need to log in before you can comment on or make changes to this bug.