Bug 170652 – test262: test262/test/built-ins/Array/S15.4.3_A2.2.js

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Joseph Pecoraro]

Summary:
Array.length should be configurable (can be deleted)

Test:
test262/test/built-ins/Array/S15.4.3_A2.2.js

Basically:
delete Array.length;
assert( !Array.hasOwnProperty("length") )

Spec:
https://tc39.github.io/ecma262/#sec-array-constructor

> The length property of the Array constructor function is 1.

https://tc39.github.io/ecma262/#sec-ecmascript-standard-built-in-objects

> Unless otherwise specified, the length property of a built-in function
> object has the attributes { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: true }.

Notes:
- Chrome and Firefox pass this test

[Joseph Pecoraro]

This affected a whole bunch of other native constructors as well:

    Array, Boolean, Date, Function, ArrayBuffer,
    Number, Object, RegExp, String, Symbol

Note to WebAssembly folks, those constructor are probably problematic as well but they aren't defined in ecma 262 so I didn't check / change them.

[Joseph Pecoraro]

Created attachment 306609 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 306610 [details]
[PATCH] Proposed Fix

This include a little cleanup of unnecessary comments.

[Build Bot]

Comment on attachment 306610 [details]
[PATCH] Proposed Fix

Attachment 306610 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/3504964

New failing tests:
ChakraCore.yaml/ChakraCore/test/es5/enumerable.js.default

[Build Bot]

Comment on attachment 306610 [details]
[PATCH] Proposed Fix

Attachment 306610 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3504981

New failing tests:
sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.3/S15.4.3_A2.2.html
ietestcenter/Javascript/15.3.3.2-1.html
ietestcenter/Javascript/15.2.3.3-4-186.html
ietestcenter/Javascript/15.2.3.3-4-191.html
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.1_Date.prototype.constructor/S15.9.5.1_A3_T2.html
ietestcenter/Javascript/15.2.3.3-4-194.html
ietestcenter/Javascript/15.2.3.3-4-201.html

[Build Bot]

Created attachment 306612 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 306610 [details]
[PATCH] Proposed Fix

Attachment 306610 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3505022

New failing tests:
sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.3/S15.4.3_A2.2.html
ietestcenter/Javascript/15.3.3.2-1.html
ietestcenter/Javascript/15.2.3.3-4-186.html
ietestcenter/Javascript/15.2.3.3-4-191.html
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.1_Date.prototype.constructor/S15.9.5.1_A3_T2.html
ietestcenter/Javascript/15.2.3.3-4-194.html
ietestcenter/Javascript/15.2.3.3-4-201.html

[Build Bot]

Created attachment 306613 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 306610 [details]
[PATCH] Proposed Fix

Attachment 306610 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3505031

New failing tests:
sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.3/S15.4.3_A2.2.html
ietestcenter/Javascript/15.3.3.2-1.html
ietestcenter/Javascript/15.2.3.3-4-186.html
ietestcenter/Javascript/15.2.3.3-4-191.html
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.1_Date.prototype.constructor/S15.9.5.1_A3_T2.html
ietestcenter/Javascript/15.2.3.3-4-194.html
ietestcenter/Javascript/15.2.3.3-4-201.html

[Build Bot]

Created attachment 306614 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 306610 [details]
[PATCH] Proposed Fix

Attachment 306610 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3505056

New failing tests:
sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.3/S15.4.3_A2.2.html
ietestcenter/Javascript/15.3.3.2-1.html
ietestcenter/Javascript/15.2.3.3-4-186.html
ietestcenter/Javascript/15.2.3.3-4-191.html
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.1_Date.prototype.constructor/S15.9.5.1_A3_T2.html
ietestcenter/Javascript/15.2.3.3-4-194.html
ietestcenter/Javascript/15.2.3.3-4-201.html

[Build Bot]

Created attachment 306616 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Joseph Pecoraro]

Created attachment 306628 [details]
[PATCH] Proposed Fix

[Build Bot]

Attachment 306628 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:82:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Created attachment 306630 [details]
[PATCH] Proposed Fix

Fix ChangeLogs

[Build Bot]

Comment on attachment 306630 [details]
[PATCH] Proposed Fix

Attachment 306630 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/3507301

New failing tests:
ChakraCore.yaml/ChakraCore/test/es5/enumerable.js.default

[Joseph Pecoraro]

> New failing tests:
> ChakraCore.yaml/ChakraCore/test/es5/enumerable.js.default

How do I rebaseline this?

[Joseph Pecoraro]

(In reply to Joseph Pecoraro from comment #17)
> > New failing tests:
> > ChakraCore.yaml/ChakraCore/test/es5/enumerable.js.default
> 
> How do I rebaseline this?

$ jscr JSTests/ChakraCore/test/jsc-lib.js JSTests/ChakraCore/test/es5/enumerable.js > JSTests/ChakraCore/test/es5/enumerable.baseline-jsc

[Joseph Pecoraro]

Created attachment 306779 [details]
[PATCH] Proposed Fix

[Michael Saboff]

Comment on attachment 306779 [details]
[PATCH] Proposed Fix

r=me

[WebKit Commit Bot]

Comment on attachment 306779 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 306779

Committed r215234: <http://trac.webkit.org/changeset/215234>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.