Summary: | test262: test262/test/annexB/language/expressions/object/__proto__-fn-name.js | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||||
Component: | JavaScriptCore | Assignee: | Joseph Pecoraro <joepeck> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, joepeck, keith_miller, mark.lam, msaboff, saam | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2017-04-08 19:47:11 PDT
Created attachment 306597 [details]
[PATCH] Proposed Fix
Comment on attachment 306597 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=306597&action=review > Source/JavaScriptCore/parser/Parser.h:110 > +enum class InferName { > + Allowed, > + Disallowed, > +}; I really couldn't come up with a good name for this, but since its static at almost every call site (except one) I do think an enum is better than a bool. Naming suggestions welcome! Comment on attachment 306597 [details] [PATCH] Proposed Fix Attachment 306597 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3503795 Number of test failures exceeded the failure limit. Created attachment 306600 [details]
Archive of layout-test-results from ews113 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 306603 [details]
[PATCH] Proposed Fix
Comment on attachment 306603 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=306603&action=review > JSTests/stress/inferred-names.js:125 > +// __proto__ name is not inferred in Object Literals if not computed. This disagrees with what your test does below. > JSTests/stress/inferred-names.js:135 > +assert( ({__proto__(){}}).__proto__.name === "__proto__" ); This isn't computed, but still has name "__proto__". Is that expected? (In reply to Saam Barati from comment #6) > Comment on attachment 306603 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=306603&action=review > > > JSTests/stress/inferred-names.js:125 > > +// __proto__ name is not inferred in Object Literals if not computed. > > This disagrees with what your test does below. > > > JSTests/stress/inferred-names.js:135 > > +assert( ({__proto__(){}}).__proto__.name === "__proto__" ); > > This isn't computed, but still has name "__proto__". Is that expected? This is a named function, nothing would or is being inferred in this case. Comment on attachment 306603 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=306603&action=review >>> JSTests/stress/inferred-names.js:125 >>> +// __proto__ name is not inferred in Object Literals if not computed. >> >> This disagrees with what your test does below. > > This is a named function, nothing would or is being inferred in this case. I'll drop this part of the comment and just point to the spec. Created attachment 306629 [details]
[PATCH] For Landing
Comment on attachment 306629 [details] [PATCH] For Landing Clearing flags on attachment: 306629 Committed r215165: <http://trac.webkit.org/changeset/215165> |