Bug 170642

Summary: [MediaStream Mac] Revert change of Mac video capture format
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: ASSIGNED ---    
Severity: Normal CC: buildbot, commit-queue, jonlee, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Patch.
none
Patch for landing. none

Description Eric Carlson 2017-04-08 12:47:01 PDT
Revert r214968 which changed macOS video capture format to kCVPixelFormatType_420YpCbCr8BiPlanarFullRange from kCVPixelFormatType_420YpCbCr8Planar because AVSampleBufferDisplayLayer sometimes fails to display the former.
Comment 1 Eric Carlson 2017-04-08 12:51:59 PDT
Created attachment 306575 [details]
Proposed patch.
Comment 2 Radar WebKit Bug Importer 2017-04-08 12:52:33 PDT
<rdar://problem/31520492>
Comment 3 Build Bot 2017-04-08 12:53:30 PDT
Attachment 306575 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:107:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Carlson 2017-04-08 13:06:10 PDT
Created attachment 306578 [details]
Patch.
Comment 5 Sam Weinig 2017-04-08 16:18:49 PDT
Comment on attachment 306578 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=306578&action=review

> Source/WebCore/ChangeLog:9
> +        * platform/mediastream/mac/AVVideoCaptureSource.mm:

Could use a bit more info about why its being reverted.
Comment 6 Eric Carlson 2017-04-08 19:10:14 PDT
Comment on attachment 306578 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=306578&action=review

>> Source/WebCore/ChangeLog:9
>> +        * platform/mediastream/mac/AVVideoCaptureSource.mm:
> 
> Could use a bit more info about why its being reverted.

Done.
Comment 7 Eric Carlson 2017-04-08 19:10:37 PDT
Created attachment 306592 [details]
Patch for landing.
Comment 8 WebKit Commit Bot 2017-04-08 19:51:22 PDT
Comment on attachment 306592 [details]
Patch for landing.

Clearing flags on attachment: 306592

Committed r215158: <http://trac.webkit.org/changeset/215158>