Summary: | [MediaStream Mac] Revert change of Mac video capture format | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||
Status: | ASSIGNED --- | ||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, jonlee, sam, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Other | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Eric Carlson
2017-04-08 12:47:01 PDT
Created attachment 306575 [details]
Proposed patch.
Attachment 306575 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:107: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 306578 [details]
Patch.
Comment on attachment 306578 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=306578&action=review > Source/WebCore/ChangeLog:9 > + * platform/mediastream/mac/AVVideoCaptureSource.mm: Could use a bit more info about why its being reverted. Comment on attachment 306578 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=306578&action=review >> Source/WebCore/ChangeLog:9 >> + * platform/mediastream/mac/AVVideoCaptureSource.mm: > > Could use a bit more info about why its being reverted. Done. Created attachment 306592 [details]
Patch for landing.
Comment on attachment 306592 [details] Patch for landing. Clearing flags on attachment: 306592 Committed r215158: <http://trac.webkit.org/changeset/215158> |