Bug 170642

Summary: [MediaStream Mac] Revert change of Mac video capture format
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: ASSIGNED    
Severity: Normal CC: buildbot, commit-queue, jonlee, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Patch.
none
Patch for landing. none

Eric Carlson
Reported 2017-04-08 12:47:01 PDT
Revert r214968 which changed macOS video capture format to kCVPixelFormatType_420YpCbCr8BiPlanarFullRange from kCVPixelFormatType_420YpCbCr8Planar because AVSampleBufferDisplayLayer sometimes fails to display the former.
Attachments
Proposed patch. (1.32 KB, patch)
2017-04-08 12:51 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch. (1.26 KB, patch)
2017-04-08 13:06 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing. (1.50 KB, patch)
2017-04-08 19:10 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2017-04-08 12:51:59 PDT
Created attachment 306575 [details] Proposed patch.
Radar WebKit Bug Importer
Comment 2 2017-04-08 12:52:33 PDT
<rdar://problem/31520492>
Build Bot
Comment 3 2017-04-08 12:53:30 PDT
Attachment 306575 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:107: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Carlson
Comment 4 2017-04-08 13:06:10 PDT
Created attachment 306578 [details] Patch.
Sam Weinig
Comment 5 2017-04-08 16:18:49 PDT
Comment on attachment 306578 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=306578&action=review > Source/WebCore/ChangeLog:9 > + * platform/mediastream/mac/AVVideoCaptureSource.mm: Could use a bit more info about why its being reverted.
Eric Carlson
Comment 6 2017-04-08 19:10:14 PDT
Comment on attachment 306578 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=306578&action=review >> Source/WebCore/ChangeLog:9 >> + * platform/mediastream/mac/AVVideoCaptureSource.mm: > > Could use a bit more info about why its being reverted. Done.
Eric Carlson
Comment 7 2017-04-08 19:10:37 PDT
Created attachment 306592 [details] Patch for landing.
WebKit Commit Bot
Comment 8 2017-04-08 19:51:22 PDT
Comment on attachment 306592 [details] Patch for landing. Clearing flags on attachment: 306592 Committed r215158: <http://trac.webkit.org/changeset/215158>
Note You need to log in before you can comment on or make changes to this bug.