Bug 170641

Summary: WebAssembly: There is a short window of time where a CodeBlock could be destroyed before all of its async compilation callbacks are called
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, commit-queue, jfbastien, keith_miller, mark.lam, msaboff
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
keith_miller: review+
patch for landing none

Saam Barati
Reported 2017-04-08 03:45:24 PDT
Thought about this while on the plane. I need to read the code again to prove to myself that this is indeed the case. The race I'm worried about is a failed compilation causing us to create a new CodeBlock before we iterate all the callbacks.
Attachments
patch (3.12 KB, patch)
2017-04-14 10:13 PDT, Saam Barati 		keith_miller: review+
DetailsFormatted DiffDiff
patch for landing (3.88 KB, patch)
2017-04-14 10:24 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-04-14 10:13:19 PDT
Created attachment 307119 [details] patch
Keith Miller
Comment 2 2017-04-14 10:17:44 PDT
Comment on attachment 307119 [details] patch r=me. Maybe we should also have the plan null out the tasks after it runs them.
Saam Barati
Comment 3 2017-04-14 10:24:08 PDT
Created attachment 307120 [details] patch for landing
Keith Miller
Comment 4 2017-04-14 10:26:12 PDT
Comment on attachment 307120 [details] patch for landing adding the clear lgtm.
WebKit Commit Bot
Comment 5 2017-04-14 11:09:38 PDT
Comment on attachment 307120 [details] patch for landing Clearing flags on attachment: 307120 Committed r215368: <http://trac.webkit.org/changeset/215368>
WebKit Commit Bot
Comment 6 2017-04-14 11:09:40 PDT
All reviewed patches have been landed. Closing bug.
Alex Christensen
Comment 7 2017-04-14 13:52:44 PDT
http://trac.webkit.org/r215373
Note You need to log in before you can comment on or make changes to this bug.