Bug 170630

Summary: Align the timers for throttled rAF to reduce power usage
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, buildbot, cdumez, cgarcia, dbates, esprehn+autocc, jonlee, kangil.han, simon.fraser, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=170719
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2017-04-07 17:24:24 PDT
Align the timers for throttled rAF to reduce power usage
Attachments
Patch (2.32 KB, patch)
2017-04-07 17:26 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2017-04-07 17:26:19 PDT
Created attachment 306553 [details] Patch
Chris Dumez
Comment 2 2017-04-08 16:04:43 PDT
Comment on attachment 306553 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306553&action=review r=me > Source/WebCore/dom/ScriptedAnimationController.cpp:313 > + Seconds alignment = (fireTime + alignmentInterval / 2).secondsSinceEpoch() % alignmentInterval; MonotonicTime has % operator, so I don't think we need .secondsSinceEpoch(), do we?
Jon Lee
Comment 3 2017-04-10 00:09:01 PDT
rdar://problem/31490620
Carlos Garcia Campos
Comment 4 2017-04-11 01:11:28 PDT
This landed in r215153, but I guess you forgot to close the bug. This broke RAF animations in GTK+ port, there must be something wrong in the aligned fire time calculation, because we are getting negative delays.
Carlos Garcia Campos
Comment 5 2017-04-11 01:21:04 PDT
Ah, wait, I think the problem is that in mac port, the timer is only used when throttling. Anyway, I'll close this bug and open a new one.
Carlos Garcia Campos
Comment 6 2017-04-11 01:22:07 PDT
Comment on attachment 306553 [details] Patch Committed r215153: <http://trac.webkit.org/changeset/215153>
Note You need to log in before you can comment on or make changes to this bug.