Bug 170593 – [CMake][Windows] WebKitGUID.lib should be built with the release CRT

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Fujii Hironori]

Source/cmake/OptionsWin.cmake has a following trick to force using /MT.

>  foreach (flag_var
>      CMAKE_CXX_FLAGS CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_RELEASE
>      CMAKE_CXX_FLAGS_MINSIZEREL CMAKE_CXX_FLAGS_RELWITHDEBINFO)
>      # Use the multithreaded static runtime library instead of the default DLL runtime.
>      string(REGEX REPLACE "/MD" "/MT" ${flag_var} "${${flag_var}}")
>
>      # No debug runtime, even in debug builds.
>      if (NOT DEBUG_SUFFIX)
>          string(REGEX REPLACE "/MTd" "/MT" ${flag_var} "${${flag_var}}")
>          string(REGEX REPLACE "/D_DEBUG" "" ${flag_var} "${${flag_var}}")
>      endif ()
>  endforeach ()

But, this trick affect only to C++, but C.
As the result, WebKitGUID.lib is build with debug CRT because it has C source files.

The below warning messages are reported by this issue.

> LINK : warning LNK4098: defaultlib 'MSVCRT' conflicts with use of other libs; use /NODEFAULTLIB:library

[Fujii Hironori]

Created attachment 306482 [details]
Patch

[Brent Fulgham]

Comment on attachment 306482 [details]
Patch

Good catch!

[WebKit Commit Bot]

Comment on attachment 306482 [details]
Patch

Clearing flags on attachment: 306482

Committed r215097: <http://trac.webkit.org/changeset/215097>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.