Summary: | Implement testing mode for disk cache | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||
Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, beidson, buildbot, cdumez, cgarcia, commit-queue, kling, ryanhaddad | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 149087, 162945, 162946, 170565 | ||||||||||
Attachments: |
|
Description
Antti Koivisto
2017-04-06 07:04:23 PDT
Created attachment 306380 [details]
patch
Created attachment 306382 [details]
patch
Created attachment 306384 [details]
patch
Comment on attachment 306384 [details] patch Clearing flags on attachment: 306384 Committed r215044: <http://trac.webkit.org/changeset/215044> All reviewed patches have been landed. Closing bug. Nice! It looks like this caused ios-simulator debug tests to exit early due to assertion failures: ASSERTION FAILED: Enumerator is not a positive power of two. hasOneBitSet(static_cast<StorageType>(t)) /Volumes/Data/slave/ios-simulator-10-debug/build/WebKitBuild/Debug-iphonesimulator/usr/local/include/wtf/OptionSet.h(85) : WTF::OptionSet<WebKit::NetworkCache::Cache::Option>::OptionSet(T) [T = WebKit::NetworkCache::Cache::Option] https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/r215053%20(431)/results.html Actually, the same is seen on El Capitan: https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r215044%20(357)/results.html I think Anders may have fixed the issue in https://trac.webkit.org/changeset/215060/webkit (In reply to Ryan Haddad from comment #9) > I think Anders may have fixed the issue in > https://trac.webkit.org/changeset/215060/webkit Bug 170565: OptionSet options need to be powers of two <https://bugs.webkit.org/show_bug.cgi?id=170565> |