Bug 170547

Summary: Implement testing mode for disk cache
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, buildbot, cdumez, cgarcia, commit-queue, kling, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149087, 162945, 162946, 170565    
Attachments:
Description Flags
patch
none
patch
none
patch none

Description Antti Koivisto 2017-04-06 07:04:23 PDT
Try to eliminate sources of randomness to make cache tests non-flaky.
Comment 1 Antti Koivisto 2017-04-06 07:16:19 PDT
Created attachment 306380 [details]
patch
Comment 2 Antti Koivisto 2017-04-06 07:20:08 PDT
Created attachment 306382 [details]
patch
Comment 3 Antti Koivisto 2017-04-06 07:37:20 PDT
Created attachment 306384 [details]
patch
Comment 4 WebKit Commit Bot 2017-04-06 11:32:50 PDT
Comment on attachment 306384 [details]
patch

Clearing flags on attachment: 306384

Committed r215044: <http://trac.webkit.org/changeset/215044>
Comment 5 WebKit Commit Bot 2017-04-06 11:32:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexey Proskuryakov 2017-04-06 12:42:54 PDT
Nice!
Comment 7 Ryan Haddad 2017-04-06 14:30:03 PDT
It looks like this caused ios-simulator debug tests to exit early due to assertion failures:
ASSERTION FAILED: Enumerator is not a positive power of two.
hasOneBitSet(static_cast<StorageType>(t))
/Volumes/Data/slave/ios-simulator-10-debug/build/WebKitBuild/Debug-iphonesimulator/usr/local/include/wtf/OptionSet.h(85) : WTF::OptionSet<WebKit::NetworkCache::Cache::Option>::OptionSet(T) [T = WebKit::NetworkCache::Cache::Option]

https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/r215053%20(431)/results.html
Comment 8 Ryan Haddad 2017-04-06 14:30:50 PDT
Actually, the same is seen on El Capitan:
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r215044%20(357)/results.html
Comment 9 Ryan Haddad 2017-04-06 14:43:07 PDT
I think Anders may have fixed the issue in https://trac.webkit.org/changeset/215060/webkit
Comment 10 David Kilzer (:ddkilzer) 2017-04-21 09:44:31 PDT
(In reply to Ryan Haddad from comment #9)
> I think Anders may have fixed the issue in
> https://trac.webkit.org/changeset/215060/webkit

Bug 170565: OptionSet options need to be powers of two
<https://bugs.webkit.org/show_bug.cgi?id=170565>