Bug 170546 – [GCrypt] Implement raw and JWK imports and exports for EC keys

• Component: New Bugs
• Status: RESOLVED FIXED

[Zan Dobersek]

[GCrypt] Implement raw and JWK imports and exports for EC keys

[Zan Dobersek]

Created attachment 306381 [details]
Patch

[Michael Catanzaro]

Comment on attachment 306381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306381&action=review

Not really sure what you're doing here, so if Jiewen is able to sanity-check this, that would be great.

> Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:60
> +static size_t uncompressedPointSizeForCurve(CryptoKeyEC::NamedCurve curve)

Nit: I would make this return an unsigned (int). size_t is semantically not right here since it's not the size of a memory buffer. The type doesn't have to match how it's used elsewhere.

> Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:70
> +static size_t uncompressedFieldElementSizeForCurve(CryptoKeyEC::NamedCurve curve)

Ditto.

> Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:160
> +    Vector<uint8_t> q;

Can you add a comment to explain what you're doing with q?

[Jiewen Tan]

Comment on attachment 306381 [details]
Patch

Didn't check if calls to gcrypt library are correct or not. Looks good to me from the semantics.

[Michael Catanzaro]

Comment on attachment 306381 [details]
Patch

OK then

[Zan Dobersek]

Comment on attachment 306381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306381&action=review

>> Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:160
>> +    Vector<uint8_t> q;
> 
> Can you add a comment to explain what you're doing with q?

OK.

[Zan Dobersek]

Created attachment 306471 [details]
Patch for landing

[Zan Dobersek]

Comment on attachment 306471 [details]
Patch for landing

Clearing flags on attachment: 306471

Committed r215086: <http://trac.webkit.org/changeset/215086>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.