Bug 170540

Summary: [GTK] Remove unneeded modules from the jhbuild
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugzilla.gnome.org/show_bug.cgi?id=760367
Bug Depends on:    
Bug Blocks: 170500    
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2017-04-06 00:52:07 PDT
We are building several modules we don't really need to build from sources. libxml, libxslt and libffi.
Attachments
Patch (3.47 KB, patch)
2017-04-06 00:54 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-04-06 00:54:32 PDT
Created attachment 306369 [details] Patch Let's start by removing what we don't ned to build. This shouldn't affect the tests.
Carlos Garcia Campos
Comment 2 2017-04-06 01:20:15 PDT
It turns out it does affect tests, there are only a few failures. The libxml version in the bot is exactly the same, so it must be libxslt. However, I can reproduce some of the failures in my laptop with even newer versions.
Carlos Garcia Campos
Comment 3 2017-04-06 04:07:25 PDT
Ok, the problem is not libxslt but libxml. It's weird because we used 2.9.1 which is what the bot has installed ii libxml2:amd64 2.9.1+dfsg1-5+deb8u4 I can also reproduce the differences with my libxml from debian testing ii libxml2:amd64 2.9.4+dfsg1-2.2
Michael Catanzaro
Comment 4 2017-04-06 07:40:42 PDT
I'd rather introduce new failures and update test expectations accordingly than continue using the older version.
Carlos Garcia Campos
Comment 5 2017-04-10 03:13:30 PDT
So, this regressed in libxml2 and we never noticed it because our tests ran fine with the old version of libxml2. However, it has been broken for our users all this time, since most of the distros are shipping a libxml2 version with the regression. This is a good example of why it's not a good idea to use old versions of our deps to run the tests.
Carlos Garcia Campos
Comment 6 2017-06-20 00:10:13 PDT
Committed r218550: <http://trac.webkit.org/changeset/218550>
Michael Catanzaro
Comment 7 2017-06-23 18:23:42 PDT
You need to add libffi to install-dependencies: libffi-dev (Debian) libffi-devel (Fedora) libffi (Arch)
Note You need to log in before you can comment on or make changes to this bug.