Bug 170529

Summary: Clean up MIMETypeRegistry::mimeTypeAssociationMap for Curl
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: WebCore Misc.Assignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, cdumez, commit-queue, dino, eric.carlson, jer.noble, koivisto, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117300    
Attachments:
Description Flags
Patch
none
Patch none

Basuke Suzuki
Reported 2017-04-05 17:14:26 PDT
The implementation of mimeTypeAssociationMap() has problem on both code cleanness and memory issue. Found two FIXME: in the code. // FIXME: Should not allocate this on the heap; use NeverDestroyed instead. // FIXME: Writing the function out like this will create a giant function. // Should use a loop instead.
Attachments
Patch (8.45 KB, patch)
2018-03-09 15:37 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (8.46 KB, patch)
2018-03-09 17:12 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-02-28 12:26:04 PST
https://github.com/webkit/webkit/commit/2d6e423b34999d6934554649c5b9b154e16fe5e8 This is the beginning of the history CURL port start using this method.
Ross Kirsling
Comment 2 2018-03-09 15:37:14 PST
Created attachment 335480 [details] Patch
Ross Kirsling
Comment 3 2018-03-09 17:12:55 PST
Created attachment 335490 [details] Patch
WebKit Commit Bot
Comment 4 2018-03-09 17:47:33 PST
Comment on attachment 335490 [details] Patch Clearing flags on attachment: 335490 Committed r229497: <https://trac.webkit.org/changeset/229497>
WebKit Commit Bot
Comment 5 2018-03-09 17:47:35 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-03-12 17:23:42 PDT
<rdar://problem/38397838>
Note You need to log in before you can comment on or make changes to this bug.