Bug 170529

Summary: Clean up MIMETypeRegistry::mimeTypeAssociationMap for Curl
Product: WebKit Reporter: Basuke Suzuki <Basuke.Suzuki>
Component: WebCore Misc.Assignee: Ross Kirsling <ross.kirsling>
Severity: Normal CC: achristensen, Basuke.Suzuki, cdumez, commit-queue, dino, eric.carlson, jer.noble, koivisto, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117300    
Description Flags
Patch none

Description Basuke Suzuki 2017-04-05 17:14:26 PDT
The implementation of mimeTypeAssociationMap() has problem on both code cleanness and memory issue. Found two FIXME: in the code.

    // FIXME: Should not allocate this on the heap; use NeverDestroyed instead.

    // FIXME: Writing the function out like this will create a giant function.
    // Should use a loop instead.
Comment 1 Basuke Suzuki 2018-02-28 12:26:04 PST

This is the beginning of the history CURL port start using this method.
Comment 2 Ross Kirsling 2018-03-09 15:37:14 PST
Created attachment 335480 [details]
Comment 3 Ross Kirsling 2018-03-09 17:12:55 PST
Created attachment 335490 [details]
Comment 4 WebKit Commit Bot 2018-03-09 17:47:33 PST
Comment on attachment 335490 [details]

Clearing flags on attachment: 335490

Committed r229497: <https://trac.webkit.org/changeset/229497>
Comment 5 WebKit Commit Bot 2018-03-09 17:47:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-03-12 17:23:42 PDT