Bug 170515

Summary: Kill any WebContent process using over 16 GB of memory.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Web Template FrameworkAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates, kling, koivisto
Priority: P2 Keywords: InRadar, Performance
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+
Patch for landing none

Andreas Kling
Reported 2017-04-05 12:22:18 PDT
If you go over 16 GB, I don't care if you're "active", what are you even doing. Time to die. <rdar://problem/29930931>
Attachments
Patch (8.49 KB, patch)
2017-04-05 12:52 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
Patch for landing (8.52 KB, patch)
2017-04-06 12:38 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2017-04-05 12:52:30 PDT
Created attachment 306302 [details] Patch
Alexey Proskuryakov
Comment 2 2017-04-05 19:36:51 PDT
16 GB should be enough for everyone.
Antti Koivisto
Comment 3 2017-04-06 03:32:11 PDT
Comment on attachment 306302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306302&action=review > Source/WTF/wtf/MemoryPressureHandler.cpp:112 > -void MemoryPressureHandler::measurementTimerFired() > +void MemoryPressureHandler::shrinkOrDie() Nice, this is now much more readable.
Antti Koivisto
Comment 4 2017-04-06 03:59:07 PDT
I think we should have tests for the memory policy. You could add internals APIs to simulate the condition and log the kill/pressure events (but not actually kill anything).
Andreas Kling
Comment 5 2017-04-06 11:35:51 PDT
(In reply to Antti Koivisto from comment #4) > I think we should have tests for the memory policy. You could add internals > APIs to simulate the condition and log the kill/pressure events (but not > actually kill anything). Absolutely. Filed bug 170558 for that.
Andreas Kling
Comment 6 2017-04-06 12:38:13 PDT
Created attachment 306410 [details] Patch for landing
WebKit Commit Bot
Comment 7 2017-04-06 13:18:56 PDT
Comment on attachment 306410 [details] Patch for landing Clearing flags on attachment: 306410 Committed r215055: <http://trac.webkit.org/changeset/215055>
WebKit Commit Bot
Comment 8 2017-04-06 13:18:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.