Summary: | Canvas is tainted when painting a video with MediaStreamTrack | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
Component: | Media | Assignee: | youenn fablet <youennf> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, dino, eric.carlson, jer.noble, rniwa | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
youenn fablet
2017-04-04 17:23:57 PDT
Created attachment 306233 [details]
Patch
Created attachment 306235 [details]
Patch
Hum, before the patch, we were only tainting canvas when using video.srcObject but not video.src. There might be something to fix there. Comment on attachment 306235 [details] Patch Attachment 306235 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3474869 New failing tests: http/tests/media/media-stream/getusermedia-with-canvas.html Created attachment 306237 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 306235 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306235&action=review > LayoutTests/http/tests/media/media-stream/resources/getUserMedia-helper.js:32 > + evalAndLog('video.srcObject = mediaStream'); Looks like you changed the test but not the results: > video.src = window.URL.createObjectURL(mediaStream) URL.createObjectURL(mediastream) has been deprecated (see https://github.com/w3c/mediacapture-main/issues/404#issuecomment-271521028 and https://webkit.org/b/167518) so this form is better. Created attachment 306245 [details]
Patch for landing
Comment on attachment 306245 [details] Patch for landing Rejecting attachment 306245 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 306245, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/ChangeLog.rej patching file LayoutTests/http/tests/media/media-stream/getusermedia-with-canvas-expected.txt patching file LayoutTests/http/tests/media/media-stream/getusermedia-with-canvas.html patching file LayoutTests/http/tests/media/media-stream/resources/getUserMedia-helper.js Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3475333 Thanks for the review. (In reply to Eric Carlson from comment #6) > Comment on attachment 306235 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=306235&action=review > > > LayoutTests/http/tests/media/media-stream/resources/getUserMedia-helper.js:32 > > + evalAndLog('video.srcObject = mediaStream'); > > Looks like you changed the test but not the results: Right! > > video.src = window.URL.createObjectURL(mediaStream) > > URL.createObjectURL(mediastream) has been deprecated (see > https://github.com/w3c/mediacapture-main/issues/404#issuecomment-271521028 > and https://webkit.org/b/167518) so this form is better. Is there something that prevents us to remove it? Created attachment 306247 [details]
Patch for landing
(In reply to youenn fablet from comment #9) > Thanks for the review. > > (In reply to Eric Carlson from comment #6) > > Comment on attachment 306235 [details] > > > > video.src = window.URL.createObjectURL(mediaStream) > > > > URL.createObjectURL(mediastream) has been deprecated (see > > https://github.com/w3c/mediacapture-main/issues/404#issuecomment-271521028 > > and https://webkit.org/b/167518) so this form is better. > > Is there something that prevents us to remove it? No. (In reply to Eric Carlson from comment #11) > > Is there something that prevents us to remove it? > > No. Patch available at https://webkit.org/b/167518 Comment on attachment 306247 [details] Patch for landing Clearing flags on attachment: 306247 Committed r214928: <http://trac.webkit.org/changeset/214928> All reviewed patches have been landed. Closing bug. |