| Summary: | Don't need to Air::reportUsedRegisters for wasm at -O1 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, buildbot, cdumez, cmarcelo, dbates, keith_miller, mark.lam, msaboff, saam | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Filip Pizlo
2017-04-04 11:08:17 PDT
Created attachment 306181 [details]
the patch
Comment on attachment 306181 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=306181&action=review r=me > Source/JavaScriptCore/b3/B3StackmapGenerationParams.h:63 > + // NOTE: This will report bogus information if you did proc.setNeedsUsedRegisters(false). Can we make it crash, at least in debug builds? > Source/JavaScriptCore/b3/air/AirLiveness.h:42 > + SuperSamplerScope samplingScope(false); > + WTF::Liveness<Adapter>::compute(); Is the reason for this change just so you can time it? (In reply to Saam Barati from comment #2) > Comment on attachment 306181 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=306181&action=review > > r=me > > > Source/JavaScriptCore/b3/B3StackmapGenerationParams.h:63 > > + // NOTE: This will report bogus information if you did proc.setNeedsUsedRegisters(false). > > Can we make it crash, at least in debug builds? I'll add an assertion. > > > Source/JavaScriptCore/b3/air/AirLiveness.h:42 > > + SuperSamplerScope samplingScope(false); > > + WTF::Liveness<Adapter>::compute(); > > Is the reason for this change just so you can time it? Yeah, it was just for timing. There was a prior patch where I had done this same hack and then lost it. It's super useful. |