Bug 170426

Summary:

[GTK][JHBuild] Fetch libvpx from a release tarball instead of git

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

WebKitGTK

Assignee:

Carlos Alberto Lopez Perez <clopez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, calvaris, cgarcia, mcatanzaro, zan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Carlos Alberto Lopez Perez 2017-04-03 15:28:09 PDT

I don't know what is the issue with the libvpx repository, but when using the JHBUILD_MIRROR feature <https://trac.webkit.org/changeset/166061> it sometimes takes ages to run the fetch operation or it even fails with a network timeout.

And, I see no reason to use the git repository.

Using a release tarball should be better in any case and will lower the disk and network needs required for building WebKitGTK.

Comment 1 Carlos Alberto Lopez Perez 2017-04-03 15:53:57 PDT

Created attachment 306134 [details]
Patch

Comment 2 Carlos Alberto Lopez Perez 2017-04-03 16:35:08 PDT

Thanks for the review.

I'm landing it with a minor diff to use the variable version on the filename.


-    <branch repo="downloads.webmproject.org"
-            module="libvpx-1.6.0.tar.bz2" version="1.6.0"
+    <branch version="1.6.0"
+            module="libvpx-${version}.tar.bz2"
+            repo="downloads.webmproject.org"

Comment 3 Carlos Alberto Lopez Perez 2017-04-03 16:40:19 PDT

Committed r214854: <http://trac.webkit.org/changeset/214854>