Bug 170417

Summary:

Web Inspector: Tooltip for close tab button should match Safari

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, joepeck, mattbaker

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2017-04-03 13:32:33 PDT

Summary: Tooltip for close tab button should match Safari Steps to Reproduce: 1. Inspect this page 2. Mouseover the close tab button for any Web Inspector tab 3. Review tooltip Expected: Safari: “Click to close this tab; Option-click to close all tabs except this one” Web Inspector: “Close tab”

Attachments
[PATCH] Proposed Fix (3.19 KB, patch) 2017-04-03 13:33 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2017-04-03 13:32:41 PDT

<rdar://problem/31378423>

Joseph Pecoraro

Comment 2 2017-04-03 13:33:25 PDT

Created attachment 306101 [details] [PATCH] Proposed Fix

Matt Baker

Comment 3 2017-04-03 13:54:02 PDT

Comment on attachment 306101 [details] [PATCH] Proposed Fix r=me

WebKit Commit Bot

Comment 4 2017-04-03 15:05:07 PDT

Comment on attachment 306101 [details] [PATCH] Proposed Fix Clearing flags on attachment: 306101 Committed r214840: <http://trac.webkit.org/changeset/214840>

WebKit Commit Bot

Comment 5 2017-04-03 15:05:08 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.