Summary: | Asynchronously decoded image frames should not be destroyed when switching encoded data buffers | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||||
Component: | Images | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||
Status: | RESOLVED DUPLICATE | ||||||||||
Severity: | Normal | CC: | buildbot, kling, koivisto, simon.fraser, thorton, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Said Abou-Hallawa
2017-04-03 11:38:10 PDT
Created attachment 306095 [details]
Patch
Comment on attachment 306095 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306095&action=review > Source/WebCore/platform/graphics/Image.h:72 > +enum class ImageFrameDestroyScope { Maybe ImageFramesToDestroy or ImageFrameDestroyBehavior > Source/WebCore/platform/graphics/Image.h:77 > + Shared It's not clear what "Shared" means here. Shared with whom? Comment on attachment 306095 [details] Patch Attachment 306095 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3466706 Number of test failures exceeded the failure limit. Created attachment 306102 [details]
Archive of layout-test-results from ews112 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 306122 [details]
Patch
Comment on attachment 306095 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306095&action=review >> Source/WebCore/platform/graphics/Image.h:72 >> +enum class ImageFrameDestroyScope { > > Maybe ImageFramesToDestroy or ImageFrameDestroyBehavior I renamed it to ImageFrameDestroyBehavior. >> Source/WebCore/platform/graphics/Image.h:77 >> + Shared > > It's not clear what "Shared" means here. Shared with whom? I renamed Shared to Synchronous. If we prevent deleting the decoded frames of the images in the viewport then there is no need for this bug. *** This bug has been marked as a duplicate of bug 170640 *** |