Bug 170380

Summary: WebAssembly: make our implementation closer to the metal, for speed
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: JavaScriptCoreAssignee: JF Bastien <jfbastien>
Status: RESOLVED WONTFIX    
Severity: Normal CC: buildbot, fpizlo, ggaren, jfbastien, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 159775    
Attachments:
Description Flags
𝔚𝔢𝔟𝔄𝔰𝔰𝔢𝔪𝔟𝔩𝔶.patch none

JF Bastien
Reported 2017-04-01 00:00:06 PDT
𝔚𝔢𝔟𝔄𝔰𝔰𝔢𝔪𝔟𝔩𝔶 should be 𝔪𝔢𝔱𝔞𝔩. Being 𝔪𝔢𝔱𝔞𝔩 and 𝔩𝔬𝔴-𝔩𝔢𝔳𝔢𝔩 makes us ＦＡＳＴ.
Attachments
𝔚𝔢𝔟𝔄𝔰𝔰𝔢𝔪𝔟𝔩𝔶.patch (281.38 KB, patch)
2017-04-01 00:00 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
JF Bastien
Comment 1 2017-04-01 00:00:50 PDT
Created attachment 306041 [details] 𝔚𝔢𝔟𝔄𝔰𝔰𝔢𝔪𝔟𝔩𝔶.patch This should make 𝔚𝔢𝔟𝔄𝔰𝔰𝔢𝔪𝔟𝔩𝔶 much faster.
Build Bot
Comment 2 2017-04-01 00:02:50 PDT
Attachment 306041 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 79 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 3 2017-04-01 11:34:19 PDT
Comment on attachment 306041 [details] 𝔚𝔢𝔟𝔄𝔰𝔰𝔢𝔪𝔟𝔩𝔶.patch 🎉
JF Bastien
Comment 4 2017-04-03 09:26:37 PDT
It's unfortunate that GTK and Windows builds do not support 𝔩𝔬𝔴-𝔩𝔢𝔳𝔢𝔩 and 𝔪𝔢𝔱𝔞𝔩 code, when MacOS and iOS do. I guess we'll have to give up some of our potential performance edge for the sake of maintainability. I'll revisit this idea exactly a year from when I originally proposed it.
Note You need to log in before you can comment on or make changes to this bug.