Bug 170340

Summary:

[css-align] Adapt place-content alignment shorthand to the new baseline syntax

Product:

WebKit

Reporter:

Javier Fernandez <jfernandez>

Component:

CSS

Assignee:

Javier Fernandez <jfernandez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, darin, hyatt, jfernandez, rniwa, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews112 for mac-elcapitan	none
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch	none

Javier Fernandez

Reported 2017-03-31 08:17:59 PDT

As we have been doing with the longhand properties, we should also adapt the CSS Box Alignment shorthands to th new syntax of the baseline-alignment values. At this point we only implement the place-content shorthand. https://drafts.csswg.org/css-align-3/#baseline-values

Attachments
Patch (14.75 KB, patch) 2017-03-31 10:02 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.17 MB, application/zip) 2017-03-31 11:12 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-elcapitan (1.80 MB, application/zip) 2017-03-31 11:15 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews103 for mac-elcapitan (915.28 KB, application/zip) 2017-03-31 11:20 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.85 MB, application/zip) 2017-03-31 12:49 PDT, Build Bot	no flags	Details
Patch (15.68 KB, patch) 2017-03-31 13:09 PDT, Javier Fernandez	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Javier Fernandez

Comment 1 2017-03-31 10:02:37 PDT

Created attachment 305980 [details] Patch

Build Bot

Comment 2 2017-03-31 11:12:26 PDT

Comment on attachment 305980 [details] Patch Attachment 305980 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3450082 New failing tests: css3/parse-place-content.html

Build Bot

Comment 3 2017-03-31 11:12:28 PDT

Created attachment 305982 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-03-31 11:15:40 PDT

Comment on attachment 305980 [details] Patch Attachment 305980 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3450074 New failing tests: css3/parse-place-content.html

Build Bot

Comment 5 2017-03-31 11:15:41 PDT

Created attachment 305984 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-03-31 11:20:06 PDT

Comment on attachment 305980 [details] Patch Attachment 305980 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3450110 New failing tests: css3/parse-place-content.html

Build Bot

Comment 7 2017-03-31 11:20:07 PDT

Created attachment 305986 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-03-31 12:49:54 PDT

Comment on attachment 305980 [details] Patch Attachment 305980 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3450354 New failing tests: css3/parse-place-content.html

Build Bot

Comment 9 2017-03-31 12:49:56 PDT

Created attachment 306003 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Javier Fernandez

Comment 10 2017-03-31 13:09:29 PDT

Created attachment 306005 [details] Patch

Dave Hyatt

Comment 11 2017-04-03 15:07:40 PDT

Comment on attachment 306005 [details] Patch r=me

WebKit Commit Bot

Comment 12 2017-04-03 16:08:45 PDT

Comment on attachment 306005 [details] Patch Clearing flags on attachment: 306005 Committed r214852: <http://trac.webkit.org/changeset/214852>

WebKit Commit Bot

Comment 13 2017-04-03 16:08:47 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.