Bug 17031

Summary: Patch to build with gcc 4.3
Product: WebKit Reporter: Stephan Binner <stbinner>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
compilation fixes none

Stephan Binner
Reported 2008-01-27 03:50:38 PST
FYI, I need these patches to make WebKit compile with current gcc 4.3 snapshots.
Attachments
compilation fixes (3.98 KB, patch)
2008-01-27 03:51 PST, Stephan Binner 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephan Binner
Comment 1 2008-01-27 03:51:41 PST
Created attachment 18720 [details] compilation fixes
Mark Rowe (bdash)
Comment 2 2008-01-27 18:05:48 PST
The change to RenderThemeGtk.cpp does not look correct per our style guidelines.
Alexey Proskuryakov
Comment 3 2008-01-28 09:34:51 PST
Please click Edit link to the right of the patch to mark it for review. This patch needs a ChangeLog (see <http://webkit.org/coding/contributing.html> for more information), and of course, Mark's comment needs to be addressed, either by fixing the code, or by explaining why violating the guidelines is unavoidable in this case.
Alexey Proskuryakov
Comment 4 2008-01-29 00:57:32 PST
The reporter has indicated (via e-mail) that he is no longer interested in this fix. Since gcc 4.3 is in pre-release state, I see no reason to keep tracking this issue, closing as WONTFIX.
Note You need to log in before you can comment on or make changes to this bug.