Bug 170295

Summary: Add missing text styles
Product: WebKit Reporter: Jon Lee <jonlee>
Component: TextAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, commit-queue, dino, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
WIP
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Patch
none
build fix
buildbot: commit-queue-
Archive of layout-test-results from ews121 for ios-simulator-wk2 none

Jon Lee
Reported 2017-03-30 12:46:11 PDT
Add missing text styles
Attachments
WIP (10.04 KB, patch)
2017-03-30 12:49 PDT, Jon Lee 		no flags
DetailsFormatted DiffDiff
WIP (10.37 KB, patch)
2017-03-30 15:59 PDT, Jon Lee 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (965.02 KB, application/zip)
2017-03-30 17:56 PDT, Build Bot 		no flags
Details
Patch (14.57 KB, patch)
2017-03-31 09:05 PDT, Jon Lee 		no flags
DetailsFormatted DiffDiff
build fix (1.48 KB, patch)
2017-04-02 17:58 PDT, Alexey Proskuryakov 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (955.06 KB, application/zip)
2017-04-02 19:28 PDT, Build Bot 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jon Lee
Comment 1 2017-03-30 12:49:32 PDT
Created attachment 305882 [details] WIP
Jon Lee
Comment 2 2017-03-30 15:59:40 PDT
Created attachment 305920 [details] WIP
Build Bot
Comment 3 2017-03-30 17:56:52 PDT
Comment on attachment 305920 [details] WIP Attachment 305920 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3443569 New failing tests: platform/ios/ios/fast/text/opticalFontWithTextStyle.html
Build Bot
Comment 4 2017-03-30 17:56:53 PDT
Created attachment 305932 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Jon Lee
Comment 5 2017-03-31 09:05:11 PDT
Created attachment 305972 [details] Patch
WebKit Commit Bot
Comment 6 2017-04-01 22:28:14 PDT
Comment on attachment 305972 [details] Patch Clearing flags on attachment: 305972 Committed r214724: <http://trac.webkit.org/changeset/214724>
WebKit Commit Bot
Comment 7 2017-04-01 22:28:15 PDT
All reviewed patches have been landed. Closing bug.
Jon Lee
Comment 8 2017-04-02 01:17:04 PDT
rdar://problem/30219503
Alexey Proskuryakov
Comment 9 2017-04-02 17:57:05 PDT
Re-opening for build fix that I need to run by EWS.
Alexey Proskuryakov
Comment 10 2017-04-02 17:58:03 PDT
Created attachment 306061 [details] build fix This will fail ios-sim, I just need to get new expected results.
Build Bot
Comment 11 2017-04-02 19:28:29 PDT
Comment on attachment 306061 [details] build fix Attachment 306061 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3462163 New failing tests: platform/ios/ios/fast/text/opticalFontWithTextStyle.html
Build Bot
Comment 12 2017-04-02 19:28:30 PDT
Created attachment 306062 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Alexey Proskuryakov
Comment 13 2017-04-02 20:14:06 PDT
Landed the build fix in http://trac.webkit.org/r214730
Note You need to log in before you can comment on or make changes to this bug.